Missing import

[jorgedch]

Software paper

openjournals/joss-reviews#4517

• Functionality:

1. The library ipywidgets is needed in requirements.txt to run the code in Generating embeddings offline

[stsievert]

Do you have a more detailed traceback? I'm not seeing any mention of ipywidgets in the repo (both in #139 and on the master branch):

(review-comments) $ pwd
/Users/scott/Developer/stsievert/salmon
(review-comments) $ grep -Hnri "ipywidgets" .
(review-comments) $ git checkout master
(master) $ grep -Hnri "ipywidgets" .
(master) $

[jorgedch]

Indeed, it's not going to show in the repo as it is a missing requirement in the packages indicated in requirements.txt. I got an error when running the example code in Generating embeddings offline and it was solved after I added ipywidgets in requirements.txt. So the problem is fixed, it's only matter of adding the package to the list.

Note: I also recommend you to sort the packages in requirements.txt in alphabetical order, it saves time as the project evolves.