Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to run local installation #135

Closed
1 task
jorgedch opened this issue Jul 7, 2022 · 2 comments · Fixed by #139
Closed
1 task

Fails to run local installation #135

jorgedch opened this issue Jul 7, 2022 · 2 comments · Fixed by #139

Comments

@jorgedch
Copy link

jorgedch commented Jul 7, 2022

Functionality

openjournals/joss-reviews#4517

  • Installation:
  1. Fails to run local installation command docker-compose build on Mac OS 12.4:
#0 110.6   Attempting uninstall: pyyaml
#0 110.6     Found existing installation: PyYAML 5.1.2
#0 110.6 Pip subprocess error:
#0 110.6 ERROR: Cannot uninstall 'PyYAML'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
#0 110.6
#0 110.6
#0 110.6 failed
#0 110.6
#0 110.6 CondaEnvException: Pip failed
#0 110.6
------
failed to solve: executor failed running [/bin/sh -c conda env update -n base --file /salmon/salmon.yml --prune]: exit code: 1
@stsievert
Copy link
Owner

stsievert commented Jul 8, 2022

Hm... I can't reproduce.

Reproduction process

The command conda env create -f salmon.yml completed successfully for me with conda 4.10.3, the version specified in the Dockerfile.

Building the container also worked for me (with Docker Desktop on macOS 10.14). I ran these commands:

git clone https://github.com/stsievert/salmon.git
cd salmon
docker-compose build
docker-compose up -d --remove-orphans

I've deployed a fix in ced3cce in #139 (which is also the latest release). Do you want to try that commit and see if it works?


Perhaps a better question... why are you trying to build the Docker containers locally? I can let you run through the Amazon AWS install process at https://docs.stsievert.com/salmon/installation.html#experimentalist.

@stsievert stsievert mentioned this issue Jul 8, 2022
13 tasks
@jorgedch jorgedch mentioned this issue Jul 8, 2022
1 task
@jorgedch
Copy link
Author

jorgedch commented Jul 8, 2022

Yes, I run the commands that you mention (so it is already the latest release), but it was getting stuck in the docker-compose build step:

git clone https://github.com/stsievert/salmon.git
cd salmon
docker-compose build

I've been running this process as it is included in the installation docs, but you are right, this step is indicated as relevant for developers and not for experimentalists. That being said, after pulling your latest changes in the review-comments branch (#139) it installs and runs correctly, so from all sides we can close this issue :)

@jorgedch jorgedch closed this as completed Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants