Use a refactored, faster implementation of the Sardinas-Patterson algorithm #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ely decodable check and in Schlinkert pruning. Should be about 80% faster
|
An informal benchmark: time tidy -AAAA --schlinkert-prune --dry-run 1password-wordlist-as-of-2021.txt An 18,176-word, non-uniquely decodable list. Old version of Tidy (v0.3.4)New list length is 15,841 With refactored UD check and Schlinkert pruning (this PR)New list length is 15,841 |
sts10
changed the title
|
I think this is good to merge as is. I'm just going to sleep on it and see if I think of any other tests I want to try before merging tomorrow. |
… probably should have gone into a different branch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of another project, @westonal refactored my implementation of Sardinas-Patterson. I then adapted it to also apply these speed-ups to Schlinkert pruning in Tidy.
The speed-up is by about 80%. Awesome!