Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promote real-time report to normal report #388

Open
xandervedder opened this issue Oct 3, 2023 · 3 comments
Open

feat: promote real-time report to normal report #388

xandervedder opened this issue Oct 3, 2023 · 3 comments
Labels
area: real-time reporting Everything that has to do with real-time reporting. enhancement good-first-issue Issues suited for newcomers hacktoberfest

Comments

@xandervedder
Copy link
Collaborator

As per #281 (comment)

@rouke-broersma
Copy link
Member

rouke-broersma commented Oct 3, 2023

Wouldn't it be safer to in-fact require a full submit of the mutation report after real-time reporting? If for any intermittent reason a result was not received by the dashboard you would now still have it because the full report is sent after the fact.

We could even use the regular mutation report POST as the trigger to delete any existing real-time results for that version of the report.

@xandervedder
Copy link
Collaborator Author

xandervedder commented Oct 3, 2023

Probably, but the scenario you are describing is how it currently works (in the open pull request).

Just checked, this isn't true.. 😅

@rouke-broersma
Copy link
Member

I'm proposing to move the deletion to the regular POST endpoint, instead of a dedicated deletion endpoint.

@xandervedder xandervedder added the area: real-time reporting Everything that has to do with real-time reporting. label Oct 27, 2023
@xandervedder xandervedder changed the title Promote real-time report to normal report feat: promote real-time report to normal report Oct 31, 2023
@xandervedder xandervedder removed this from the v0.15 milestone Mar 29, 2024
@lex-funy lex-funy added the good-first-issue Issues suited for newcomers label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: real-time reporting Everything that has to do with real-time reporting. enhancement good-first-issue Issues suited for newcomers hacktoberfest
Projects
Status: Backlog
Development

No branches or pull requests

3 participants