-
Notifications
You must be signed in to change notification settings - Fork 17
Comparing changes
Open a pull request
base repository: strongswan/govici
base: v0.5.1
head repository: strongswan/govici
compare: v0.5.2
- 9 commits
- 7 files changed
- 1 contributor
Commits on Jul 25, 2021
-
We use github's CI instead of travis now. Signed-off-by: Nick Rosbrook <nr@enr0n.net>
Configuration menu - View commit details
-
Copy full SHA for a2212d7 - Browse repository at this point
Copy the full SHA a2212d7View commit details -
README: remove old reportcard badge
Signed-off-by: Nick Rosbrook <nr@enr0n.net>
Configuration menu - View commit details
-
Copy full SHA for ab13103 - Browse repository at this point
Copy the full SHA ab13103View commit details
Commits on Aug 22, 2021
-
session: remove TestNextEventAfterFailedSubscribe
TestNextEventAfterFailedSubscribe tests whether a specific error is sent on event error channel. This is not a good test in the sense that it is for internal behavior, not the API. Signed-off-by: Nick Rosbrook <nr@enr0n.net>
Configuration menu - View commit details
-
Copy full SHA for 9c242fb - Browse repository at this point
Copy the full SHA 9c242fbView commit details -
session: fix TestCommandRequest
The daemon key may not always be 'charon' (e.g. it is charon-systemd on my system), so instead just make sure there is a non-empty value set. Signed-off-by: Nick Rosbrook <nr@enr0n.net>
Configuration menu - View commit details
-
Copy full SHA for 470a5cd - Browse repository at this point
Copy the full SHA 470a5cdView commit details -
transport: use io.ReadFull in recv()
Currently, recv() does not check the number of bytes read into the buffer during its Read() calls. This means that in some cases a partial read may occur, which will cause the next recv() call to read the packet length incorrectly. In particular, this may be a huge number and cause a huge buffer allocation. To fix this, simply use io.ReadFull to make sure we do not get partial reads. Related: #34 Signed-off-by: Nick Rosbrook <nr@enr0n.net>
Configuration menu - View commit details
-
Copy full SHA for dc4baea - Browse repository at this point
Copy the full SHA dc4baeaView commit details -
events: do not call SetReadDeadline() in listen()
In 6dc3797, a read deadline was added so that listen() would not block forever on recv() calls when the listener was closed. This was necessary because the event listener was Close()'d by cancelling a context. If recv() was blocking, the loop would not ever notice the closed context. In the current logic, Close() will call el.conn.Close() which is all we really need to stop the event loop. To do this, however, just return on any error from recv(). With this, strip out the perr logic as there is no longer a need for it. And, strip out the ctx and cancel logic because as noted, closing the connection and returning on error from recv() is sufficient. Overall, the reduction of complexity should make this code easier to maintain going forward. Related: #34 Signed-off-by: Nick Rosbrook <nr@enr0n.net>
Configuration menu - View commit details
-
Copy full SHA for 364d2fb - Browse repository at this point
Copy the full SHA 364d2fbView commit details -
transport: remove errTransport
In general, the const err approach is not great. In the case of transport, the errTransport "wrapping" sometimes masks more useful io errors. Remove the errTransport, and do not "wrap" transport errors. Signed-off-by: Nick Rosbrook <nr@enr0n.net>
Configuration menu - View commit details
-
Copy full SHA for bc200e3 - Browse repository at this point
Copy the full SHA bc200e3View commit details
Commits on Aug 25, 2021
-
CHANGELOG.md: add note about bug fix
Signed-off-by: Nick Rosbrook <nr@enr0n.net>
Configuration menu - View commit details
-
Copy full SHA for 906a49a - Browse repository at this point
Copy the full SHA 906a49aView commit details -
CHANGELOG.md: bump version to v0.5.2
Signed-off-by: Nick Rosbrook <nr@enr0n.net>
Configuration menu - View commit details
-
Copy full SHA for 4450ae8 - Browse repository at this point
Copy the full SHA 4450ae8View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.5.1...v0.5.2