Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: strongswan/govici
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.5.1
Choose a base ref
...
head repository: strongswan/govici
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.5.2
Choose a head ref
  • 9 commits
  • 7 files changed
  • 1 contributor

Commits on Jul 25, 2021

  1. build: remove .travis.yml

    We use github's CI instead of travis now.
    
    Signed-off-by: Nick Rosbrook <nr@enr0n.net>
    enr0n committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    a2212d7 View commit details
    Browse the repository at this point in the history
  2. README: remove old reportcard badge

    Signed-off-by: Nick Rosbrook <nr@enr0n.net>
    enr0n committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    ab13103 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2021

  1. session: remove TestNextEventAfterFailedSubscribe

    TestNextEventAfterFailedSubscribe tests whether a specific error is sent
    on event error channel. This is not a good test in the sense that it is
    for internal behavior, not the API.
    
    Signed-off-by: Nick Rosbrook <nr@enr0n.net>
    enr0n committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    9c242fb View commit details
    Browse the repository at this point in the history
  2. session: fix TestCommandRequest

    The daemon key may not always be 'charon' (e.g. it is charon-systemd on
    my system), so instead just make sure there is a non-empty value set.
    
    Signed-off-by: Nick Rosbrook <nr@enr0n.net>
    enr0n committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    470a5cd View commit details
    Browse the repository at this point in the history
  3. transport: use io.ReadFull in recv()

    Currently, recv() does not check the number of bytes read into the
    buffer during its Read() calls. This means that in some cases a partial
    read may occur, which will cause the next recv() call to read the packet
    length incorrectly. In particular, this may be a huge number and cause a
    huge buffer allocation. To fix this, simply use io.ReadFull to make sure
    we do not get partial reads.
    
    Related: #34
    
    Signed-off-by: Nick Rosbrook <nr@enr0n.net>
    enr0n committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    dc4baea View commit details
    Browse the repository at this point in the history
  4. events: do not call SetReadDeadline() in listen()

    In 6dc3797, a read deadline was added
    so that listen() would not block forever on recv() calls when the
    listener was closed. This was necessary because the event listener was
    Close()'d by cancelling a context. If recv() was blocking, the loop
    would not ever notice the closed context.
    
    In the current logic, Close() will call el.conn.Close() which is all we
    really need to stop the event loop. To do this, however, just return on
    any error from recv(). With this, strip out the perr logic as there is
    no longer a need for it. And, strip out the ctx and cancel logic because
    as noted, closing the connection and returning on error from recv() is
    sufficient.
    
    Overall, the reduction of complexity should make this code easier to
    maintain going forward.
    
    Related: #34
    
    Signed-off-by: Nick Rosbrook <nr@enr0n.net>
    enr0n committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    364d2fb View commit details
    Browse the repository at this point in the history
  5. transport: remove errTransport

    In general, the const err approach is not great. In the case of
    transport, the errTransport "wrapping" sometimes masks more useful io
    errors. Remove the errTransport, and do not "wrap" transport errors.
    
    Signed-off-by: Nick Rosbrook <nr@enr0n.net>
    enr0n committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    bc200e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. CHANGELOG.md: add note about bug fix

    Signed-off-by: Nick Rosbrook <nr@enr0n.net>
    enr0n committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    906a49a View commit details
    Browse the repository at this point in the history
  2. CHANGELOG.md: bump version to v0.5.2

    Signed-off-by: Nick Rosbrook <nr@enr0n.net>
    enr0n committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    4450ae8 View commit details
    Browse the repository at this point in the history
Loading