Account for / routes in RestAdapter.allRoutes#488
Open
getsnoopy wants to merge 1 commit intostrongloop:masterfrom
Open
Account for / routes in RestAdapter.allRoutes#488getsnoopy wants to merge 1 commit intostrongloop:masterfrom
getsnoopy wants to merge 1 commit intostrongloop:masterfrom
Conversation
Previously, there was a bug in RestAdapter.allRoutes where the paths for routes which were mounted at / would return as empty instead of the expected / because of some trailing slash removal logic that was faulty. This commit fixes this so that it accounts for cases where the path itself is /, so the logic will leave those unchanged. Fixes strongloop#487
getsnoopy
requested review from
ebarault,
fabien,
ritch and
zbarbuto
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, there was a bug in RestAdapter.allRoutes where the paths for routes which were mounted at
/would return as empty instead of the expected/because of some trailing slash removal logic that was faulty. This commit fixes this so that it accounts for cases where the path itself is/, so the logic will leave those unchanged.Fixes #487
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine