-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEMVER-MAJOR] Removed unused user properties #2299
Conversation
@slnode test please |
Please see [related code change](https://github.com/strongloop/loopback/pull/2174) here. | ||
|
||
## Removing unused user properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use imperative on L23, pleas do the same for consistency.
## Remove unused user properties
Updated the description |
```js | ||
//user.json | ||
"credentials": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please start at the top level of model JSON file to make it more clear where to add this snippet. Also use json
for highlighting (you can check the source of my comment to see how to do it in markdown):
{
"name": "MyUser",
"base": "User",
"properties": {
"credentials": { "type": "object" },
"challenges": { "type": "object" },
"status": "string",
"created": "date",
"lastUpdated": "date"
}
}
Two more comments, the PR looks good otherwise. No further review is necessary, please squash the commits before landing (and rebase on top of the current master). |
6dc2bd8
to
42c3b38
Compare
- credentials - challenges - status - created - lastUpdated
42c3b38
to
817e76e
Compare
connect to #1854
Removed properties