Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReaderInputOptions access to the inner list #248

Closed
ghost opened this issue Jul 25, 2022 · 1 comment · Fixed by #254
Closed

ReaderInputOptions access to the inner list #248

ghost opened this issue Jul 25, 2022 · 1 comment · Fixed by #254
Assignees

Comments

@ghost
Copy link

ghost commented Jul 25, 2022

Summary

Feature Request.
With the current api of the ReaderInputOptions
https://stripe.dev/stripe-terminal-android/external/com.stripe.stripeterminal.external.models/-reader-input-options/index.html
Developers can't base their logic on specific input options, compared to iOS SDK.

Example: If I'm as a developer want to check if the [Swipe] input option is available during the payment - I simply can't, because the inner list of the options is not available from the interface.

Possible solution would be to have any kind of checking interface, e.g.:

  • Public read access to the inner list of [ReaderInputOption] objects
  • New method [.contains(ReaderInputOption)] that can report if a specific option is contained in the ReaderInputOptions object

Code to reproduce

None

Android version

Any

Impacted devices (Android devices or readers)

Chipper 2X and WisePad3

SDK version

2.10.2

Other information

None

@ugochukwu-stripe
Copy link
Contributor

@fh-apanfilov this issue should be resolved in 2.13.0. Thanks for the detailed request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants