Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tipUnits in metaData does not contain tipUnits #228

Closed
yogen-p opened this issue Apr 22, 2022 · 5 comments
Closed

tipUnits in metaData does not contain tipUnits #228

yogen-p opened this issue Apr 22, 2022 · 5 comments
Assignees

Comments

@yogen-p
Copy link

yogen-p commented Apr 22, 2022

Summary

The tipping value is not in the response of the processPaymentCallback for WisePad3. So, I need to store the original transactionAmount and then substract it from paymentIntent.amount.

Code to reproduce

Reproducible every time I make a payment with tip
Terminal.getInstance().processPayment(paymentIntent, processPaymentCallback)

Android version

12

Impacted devices (Android devices or readers)

Doesn't matter

SDK version

2.8.1

Other information

This transaction had a transactionAmount of £10.00(1000 units) and a tip of £2.00(200 units)
image

@sjl-stripe
Copy link
Collaborator

@yogen-p thanks for the report. We're tracking this issue with our internal issue tracker and it will be addressed in a future release.

@chr-stripe chr-stripe self-assigned this Aug 3, 2022
@sjl-stripe
Copy link
Collaborator

We've added this functionality with version 2.15.0. You can now see the tip amount through the PaymentIntent object in the processPayment callback.

@yogen-p
Copy link
Author

yogen-p commented Feb 7, 2023

Hi @sjl-stripe This still seems to be broken on the latest SDK 2.17.0

image

@billfinn-stripe
Copy link
Collaborator

@yogen-p -- can you clarify the problem you are seeing? The amountTip is available via paymentIntent.amountDetails.tip.amount in the processPayment callback.

Setting the on-reader tip amount in the metadata will not work because we only send the metadata to stripe.com when creating the payment intent. We are looking into supporting an updatePaymentIntent SDK method which would allow you to update the metadata after creating the PI.

@yogen-p
Copy link
Author

yogen-p commented Feb 8, 2023

Hi @billfinn-stripe , Thanks for clarifying that. The amountTip is indeed available via paymentIntent.amountDetails.tip.amount.

I was looking in the wrong place. Apologies for the trouble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@yogen-p @billfinn-stripe @lins-stripe @sjl-stripe @chr-stripe and others