Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of fixes for PHP 7.4 #725

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Couple of fixes for PHP 7.4 #725

merged 2 commits into from
Aug 30, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries

Fixes a couple of warnings for PHP 7.4.

The PHP 7.4 builds are still red, but that's because php-cs-fixer doesn't support 7.4 yet. The test suite is passing without warnings.

Fixes #723.

@ob-stripe ob-stripe mentioned this pull request Aug 30, 2019
26 tasks
@ankitkbl
Copy link

array_key_exists(): Using array_key_exists() on objects is deprecated. Use isset() or property_exists() instead in /var/www/html/backend/vendor/stripe/stripe-php/lib/ApiRequestor.php on line 402

same error coming again

@ankitkbl
Copy link

i'm using PHP 7.4.3 (cli)

@ob-stripe
Copy link
Contributor Author

@ankitkbl Make sure you're using stripe-php 7.0.0 or more recent. If you're still observing this problem after upgrading, please open a new issue on GitHub.

@andrii-pukhalevych
Copy link

Can it be back ported to version 6?

@remi-stripe
Copy link
Contributor

@andrii-pukhalevych Unfortunately we don't backport fixes like this. We recommend upgrading to the latest instead. Otherwise you can fork the library and patch this locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants