Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent variable from being parsed #676

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Conversation

yoavf
Copy link
Contributor

@yoavf yoavf commented Jun 26, 2019

The error message in \Stripe\CustomerBalanceTransaction::update contains a variable that will be parsed since the string is enclosed in double quotes and the $ is not escaped

The error message in `\Stripe\CustomerBalanceTransaction::update` contains a variable that will be parsed since the string is enclosed in double quotes and the `$` is not escaped
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Nice catch, thanks @yoavf!

@ob-stripe ob-stripe self-assigned this Jun 26, 2019
@ob-stripe ob-stripe merged commit 8f8f5a6 into stripe:master Jun 26, 2019
@ob-stripe
Copy link
Contributor

Fixed in 6.39.2.

@yoavf yoavf deleted the patch-1 branch November 5, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants