Only use HTTP/2 with curl >= 7.60.0 #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
When using HTTP/2, Stripe's API servers are configured to send a GOAWAY frame after 1000 requests. curl versions older than 7.60.0 had a bug where curl would ignore the GOAWAY frame (curl/curl#2416).
This PR changes the behavior of
CurlClientso that we only setCURLOPT_HTTP_VERSIONtoCURL_HTTP_VERSION_2TLSif the version of curl is >= 7.60.0 unless the user explicitly overrides this, either by settingCURLOPT_HTTP_VERSIONthemselves (this was already the case prior to this PR) or by callingsetEnableHttp2(true)on theCurlClientinstance.