Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted phpdocs to match API docs as of 2019-02-25 #601

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Adjusted phpdocs to match API docs as of 2019-02-25 #601

merged 1 commit into from
Feb 25, 2019

Conversation

nickdnk
Copy link
Contributor

@nickdnk nickdnk commented Feb 25, 2019

Hello guys

Back with some phpdoc updates. This is what I found this time around. Mostly just new or removed props, but we also have a somewhat critical typo in application_fee_amount on PaymentIntent as well as some new event constants.

Invoice seems to have both date and created on the docs, but only created is described, and since I assume they do the same I removed date.

Let me know if this looks good.

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickdnk Thanks a lot for the hard work as usual. I left a lot of comments this time, hope it's okay!

lib/BankAccount.php Outdated Show resolved Hide resolved
lib/Card.php Outdated Show resolved Hide resolved
lib/Event.php Outdated Show resolved Hide resolved
lib/Event.php Outdated Show resolved Hide resolved
lib/Event.php Outdated Show resolved Hide resolved
lib/Event.php Outdated Show resolved Hide resolved
lib/Event.php Show resolved Hide resolved
lib/Person.php Outdated Show resolved Hide resolved
@nickdnk
Copy link
Contributor Author

nickdnk commented Feb 25, 2019

@remi-stripe I think I got all of them. I just noticed the problem with removing event constants as I received your reply. I forgot I was not in phpdoc-land for a second :)

@remi-stripe remi-stripe merged commit baef9fe into stripe:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants