Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phpdoc of nested resources #591

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Fix phpdoc of nested resources #591

merged 1 commit into from
Jan 31, 2019

Conversation

franmomu
Copy link
Contributor

Hi there,

Phpdoc references to the $id as an array and it is a string. And also the {_create,_retrieve,_update,_delete}NestedResource methods expect a string.

@brandur-stripe
Copy link
Contributor

Thanks @franmomu!

@brandur-stripe brandur-stripe merged commit 49954f1 into stripe:master Jan 31, 2019
@brandur-stripe
Copy link
Contributor

Released as 6.29.2.

@franmomu franmomu deleted the fix_phpdoc_string_id branch January 31, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franmomu @brandur-stripe