Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static methods for accessing nested resources #383

Merged
merged 1 commit into from
Oct 25, 2017

Conversation

ob-stripe
Copy link
Contributor

@ob-stripe ob-stripe commented Oct 24, 2017

r? @brandur-stripe
cc @stripe/api-libraries

Fixes #363.

Basically the same thing as stripe/stripe-ruby#597 and stripe/stripe-python#350, but with less fancy metaprogramming because PHP 😢

@ob-stripe ob-stripe force-pushed the ob-nested-resource-class-methods branch from 365b4d8 to 4006553 Compare October 24, 2017 16:54
@brandur-stripe
Copy link
Contributor

Wow @ob-stripe, what are you doing to fit 36 hours into a day? Whatever it is, I want it ;)

Nice work! There were a couple build failures in the matrix, but I think they were intermittent problems. Going to go ahead and merge this.

@brandur-stripe brandur-stripe merged commit 63be833 into master Oct 25, 2017
@brandur-stripe brandur-stripe deleted the ob-nested-resource-class-methods branch October 25, 2017 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants