Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up examples #1773

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Clean up examples #1773

merged 3 commits into from
Oct 8, 2024

Conversation

jar-stripe
Copy link
Contributor

Why?

In our recent SDK release we added a couple new examples along with a template to make it easy for us to create new examples. The names of the examples and the template were confusing and hard to understand and our documentation around examples was lacking. This PR fixes/clarifies the names and added comments to explain each new example.

What?

  • renamed new_example.php to ExampleTemplate.php and added file comment template
  • renamed stripe_webhook_handler.php to ThinEventWebhookHandler.php and added file comment describing the example
  • added comment to MeterEventStream.php describing the example

added file comments to other examples
renamed stripe_webhook_handler to ThinEventWebhookHandler for clarity
@jar-stripe jar-stripe merged commit 2b237f1 into master Oct 8, 2024
22 checks passed
@jar-stripe jar-stripe deleted the jar/clean-up-examples branch October 8, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants