Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in docblock CurlClient::executeStreamingRequestWithRetries #1171

Merged

Conversation

jerowork
Copy link
Contributor

@jerowork jerowork commented Aug 11, 2021

Description

A small PHP DocBlock typo fix.

Parameter $readBodyChunk was set in docblock with an @ instead of a $.
This resulted in failing annotation parsing (doctrine/annotations):

[Semantical Error] The annotation "@readBodyChunk" in method Stripe\HttpClient\CurlClient::executeStreamingRequestWithRetries() was never imported. Did you maybe forget to add a "use" statement for this annotation?

Parameter `$readBodyChunk` was set in docblock with an `@` instead of a `$`.
This resulted in failing annotation parsing (doctrine/annotations):

```
[Semantical Error] The annotation "@readBodyChunk" in method Stripe\HttpClient\CurlClient::executeStreamingRequestWithRetries() was never imported. Did you maybe forget to add a "use" statement for this annotation?
```
@CLAassistant
Copy link

CLAassistant commented Aug 11, 2021

CLA assistant check
All committers have signed the CLA.

@jerowork jerowork marked this pull request as ready for review August 11, 2021 13:42
@richardm-stripe richardm-stripe merged commit 3b42471 into stripe:master Aug 11, 2021
@richardm-stripe
Copy link
Contributor

Hello @jerowork, thank you for the contribution! I have merged it and it will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants