stripe-node v7.0.0 #606
Merged
stripe-node v7.0.0 #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
reviewed
May 4, 2019
|
@rattrayalex-stripe @irace-stripe We try to keep the commit history as clean as possible in the libraries repos. Do you mind squashing the commits here? I think there should only be two so far in this branch:
|
|
@ob-stripe @rattrayalex-stripe This branch has now been rebased to have a clean commit history. |
|
Added another branch off of this one: #610 |
|
@rattrayalex-stripe @irace-stripe You should rebase on |
|
I might actually wait to rebase master till we're removed deprecated things too, so we can rebase once just before merging/releasing. |
ob-stripe
changed the title
rattrayalex-stripe
force-pushed
the
v7.0.0
branch
from
df2b214
to
762b6a9
Compare
|
Alright, I think this is ready to go! cc @ob-stripe I intend to merge and release within an hour or two. |
rattrayalex-stripe
force-pushed
the
v7.0.0
branch
from
762b6a9
to
f780ff3
Compare
* Add lebab and a script to run it * lebab transform: arrow * lebab transform: arg-rest * lebab transform: arg-spread * lebab transform: obj-method * lebab transform: obj-shorthand * lebab transform: let * lebab transform: template * lebab transform: default-param * lebab transform: destruct-param * lebab transform: includes * Revert "Add lebab and a script to run it" This reverts commit 70fd492. * Revert "lebab transform: destruct-param" because its changes didn't seem good. This reverts commit b56f52d. * Revert "lebab transform: default-param" because it seems dangerous / backwards-incompatible. This reverts commit 7eba992. * Unrelated: mark 8.1 as minimum 8-series version * Add mocha-only script * Use arrows in more places * Loosen some eslint rules I don't love
* Misc. manual formatting * Fix some unit tests * Roll back path argument name changes * Misc. manual formatting
rattrayalex-stripe
force-pushed
the
v7.0.0
branch
2 times, most recently
from
766b201
to
9fdad65
Compare
) * Drop support for optional url params * Delete nested resource files * Remove urlData * Extract urlParams from path instead of manual definition Verified this is no different with: ```js const urlParams = utils.extractUrlParams(spec.path || ''); if ( !(spec.urlParams || []).every((x, i) => urlParams[i] === x) || (spec.urlParams || []).length !== urlParams.length ) { throw Error( 'mismatch' + JSON.stringify(urlParams) + JSON.stringify(spec.urlParams) ); } ``` inside StripeMethod * Remove manually specified urlParams * Add a deprecation error message * Revert "Delete nested resource files" This reverts commit d88a3e7. * Fix nested resources for non-curried urlParams and update tests to demonstrate their use * Refactor makeRequest * Revert "Revert "Delete nested resource files"" This reverts commit e5eccb8.
* Extract separate resources file (to aid with code generation) * Remove resources that were removed in #625 https://github.com/stripe/stripe-node/pull/625/files#diff-d3dd6c4fd6f915f29d42e4081dc817a8L85
rattrayalex-stripe
force-pushed
the
v7.0.0
branch
from
9fdad65
to
cdea81a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major release of stripe-node, dropping support for several old versions of Node and deprecated methods.
The migration guide contains a detailed list of backwards-incompatible changes with upgrade instructions.
cc @stripe/api-libraries
cc @ob-stripe @paulasjes-stripe @robz-stripe
idfor single positional arguments (Useidfor single positional arguments #611)invoices.retrieveUpcoming()(Remove legacy parameter support in invoices.retrieveUpcoming() #621)follow-on
self(Removed most instances of 'self' #615)