Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: stripe/stripe-node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 64b4b9fc8f3ba2382d9d313371dab255347f4a56
Choose a base ref
...
head repository: stripe/stripe-node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9e1f4899e6869c15523387149111794b8a7a1e94
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Jan 22, 2020

  1. Gracefully handle a missing subprocess module 

    As reported in #773, it seems that certain sandboxed environments like
CloudFlare Workers don't provide a `subprocess` module, and that causes
Node to throw when we try to require it.

Because the only thing we need `subprocess` for is getting `uname`, here
we extend the already-existing infrastructure built to gracefully handle
errors to also be able to handle this new error case.

Fixes #773.
    @brandur
    brandur committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    9e1f489 View commit details
    Browse the repository at this point in the history
Loading