Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add support for macCatalyst to use the form sheet presentation, like in iPad #2023

Closed
sergiocampama opened this issue Oct 6, 2022 · 1 comment
Closed

[Feature] Add support for macCatalyst to use the form sheet presentation, like in iPad #2023

sergiocampama opened this issue Oct 6, 2022 · 1 comment
Assignees
@ramont-stripe
Labels
fixed in master Fixed in master, awaiting next update kind:improvement triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@sergiocampama
Copy link

Is your feature request related to a problem? Please describe.

More than a problem, seems to be something that was overlooked, probably because macCatalyst hasn't been massively used yet.

Describe the solution you'd like

macCatalyst should be treated similar to how iPads are treated when presenting view controllers.

Describe alternatives you've considered

Forking stripe-ios and use custom presentation logic.
@sergiocampama sergiocampama mentioned this issue Oct 6, 2022
Closed
@ramont-stripe ramont-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Oct 6, 2022
@ramont-stripe ramont-stripe self-assigned this Oct 6, 2022
@ramont-stripe
Copy link
Contributor

Fixed in v22.8.4 🎉

@ramont-stripe ramont-stripe added the fixed in master Fixed in master, awaiting next update label Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramont-stripe ramont-stripe

Labels
fixed in master Fixed in master, awaiting next update kind:improvement triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sergiocampama @ramont-stripe