Use a specified spec version for stripe-mock tests #3118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helenye-stripe
requested review from
xavdid-stripe
and removed request for
a team
helenye-stripe
changed the base branch from
master
to
mbroshi/update-beta-fixture-tests
helenye-stripe
merged commit 0c10a3d
into
mbroshi/update-beta-fixture-tests
3 of 4 checks passed
helenye-stripe
added a commit
that referenced
this pull request
Apr 29, 2025
* Use json files instead of stripe mock * Add additional failing endpoints fixtures * Use a specified spec version for stripe-mock tests (#3118) * Empty commit --------- Co-authored-by: Helen Ye <helenye@stripe.com> Co-authored-by: helenye-stripe <111009531+helenye-stripe@users.noreply.github.com>
helenye-stripe
added a commit
that referenced
this pull request
Apr 30, 2025
* Use json files instead of stripe mock (#3115) * Use json files instead of stripe mock * Add additional failing endpoints fixtures * Use a specified spec version for stripe-mock tests (#3118) * Empty commit --------- Co-authored-by: Helen Ye <helenye@stripe.com> Co-authored-by: helenye-stripe <111009531+helenye-stripe@users.noreply.github.com> * Update generated code (#3102) * Update generated code for v1675 * Update generated code for v1713 * Update generated code for v1718 * Update generated code for v1719 * Update generated code for v1719 * Update generated code for v1719 --------- Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com> Co-authored-by: Ramya Rao <100975018+ramya-stripe@users.noreply.github.com> Co-authored-by: helenye-stripe <111009531+helenye-stripe@users.noreply.github.com> --------- Co-authored-by: Michael Broshi <94012587+mbroshi-stripe@users.noreply.github.com> Co-authored-by: stripe-openapi[bot] <105521251+stripe-openapi[bot]@users.noreply.github.com> Co-authored-by: Ramya Rao <100975018+ramya-stripe@users.noreply.github.com>
helenye-stripe
added a commit
that referenced
this pull request
Apr 30, 2025
* Use json files instead of stripe mock (#3115) * Use json files instead of stripe mock * Add additional failing endpoints fixtures * Use a specified spec version for stripe-mock tests (#3118) * Empty commit --------- Co-authored-by: Helen Ye <helenye@stripe.com> Co-authored-by: helenye-stripe <111009531+helenye-stripe@users.noreply.github.com> * Update generated code (#3102) * Update generated code for v1675 * Update generated code for v1713 * Update generated code for v1718 * Update generated code for v1719 * Update generated code for v1719 * Update generated code for v1719 --------- Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com> Co-authored-by: Ramya Rao <100975018+ramya-stripe@users.noreply.github.com> Co-authored-by: helenye-stripe <111009531+helenye-stripe@users.noreply.github.com> --------- Co-authored-by: Michael Broshi <94012587+mbroshi-stripe@users.noreply.github.com> Co-authored-by: stripe-openapi[bot] <105521251+stripe-openapi[bot]@users.noreply.github.com> Co-authored-by: Ramya Rao <100975018+ramya-stripe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We modified stripe-mock to allow spec/fixtures version, and due to some mismatches between codegen/spec in the last major, we were having issues. Let's update to pull spec/fixture version here.
TEST USING LATEST OPENAPI
What?
Adds a step to manually pull the relevant spec/fixtures for testing.
Tested in CI in this branch #3117
See Also