Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisputeEvidenceOptions - inconsistent field names #1561

Closed
ydenega opened this issue Mar 29, 2019 · 2 comments · Fixed by #1482
Closed

DisputeEvidenceOptions - inconsistent field names #1561

ydenega opened this issue Mar 29, 2019 · 2 comments · Fixed by #1482

Comments

@ydenega
Copy link

ydenega commented Mar 29, 2019

DisputeEvidenceOptions class fields that hold ID of uploaded file are consistently named with 'FileId' at the end, for example, ServiceDocumentationFileId.

duplicate_charge_documentation, according to Stripe API documentation, holds ID of file upload.
However DuplicateChargeDocumentation field does not follow this naming pattern,

@remi-stripe
Copy link
Contributor

Thanks for the report. Since this is a breaking change, we'll release this with our next major version.

@ob-stripe
Copy link
Contributor

As of version 27.0.0, the parameter is named DuplicateChargeDocumentationFileId to be consistent with other parameters:

[JsonProperty("duplicate_charge_documentation")]
public string DuplicateChargeDocumentationFileId { get; set; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants