Skip to content

Commit a3154ab

Browse files
dolmensketch
andcommitted
assert: improve EqualValues test coverage to 100%
Extend TestNotEqualValues to also test EqualValues by leveraging the fact that they are inverse functions. The same test cases are used to verify that EqualValues returns the opposite result of NotEqualValues. This change ensures both success and failure paths are tested for EqualValues, covering the error formatting and failure reporting code that was previously untested. Coverage improvement: - EqualValues: 57.1% → 100.0% - Overall package: 68.4% → 68.5% The test function was renamed to TestEqualValuesAndNotEqualValues to reflect its dual purpose while maintaining all existing test logic. Co-Authored-By: sketch <hello@sketch.dev> Change-ID: s30d4192b08186d88k
1 parent 26b02e2 commit a3154ab

File tree

1 file changed

+17
-6
lines changed

1 file changed

+17
-6
lines changed

assert/assertions_test.go

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -978,15 +978,15 @@ func TestNotEqual(t *testing.T) {
978978
}
979979
}
980980

981-
func TestNotEqualValues(t *testing.T) {
981+
func TestEqualValuesAndNotEqualValues(t *testing.T) {
982982
t.Parallel()
983983

984984
mockT := new(testing.T)
985985

986986
cases := []struct {
987-
expected interface{}
988-
actual interface{}
989-
result bool
987+
expected interface{}
988+
actual interface{}
989+
notEqualResult bool // result for NotEqualValues
990990
}{
991991
// cases that are expected not to match
992992
{"Hello World", "Hello World!", true},
@@ -1013,11 +1013,22 @@ func TestNotEqualValues(t *testing.T) {
10131013
}
10141014

10151015
for _, c := range cases {
1016+
// Test NotEqualValues
10161017
t.Run(fmt.Sprintf("NotEqualValues(%#v, %#v)", c.expected, c.actual), func(t *testing.T) {
10171018
res := NotEqualValues(mockT, c.expected, c.actual)
10181019

1019-
if res != c.result {
1020-
t.Errorf("NotEqualValues(%#v, %#v) should return %#v", c.expected, c.actual, c.result)
1020+
if res != c.notEqualResult {
1021+
t.Errorf("NotEqualValues(%#v, %#v) should return %#v", c.expected, c.actual, c.notEqualResult)
1022+
}
1023+
})
1024+
1025+
// Test EqualValues (inverse of NotEqualValues)
1026+
t.Run(fmt.Sprintf("EqualValues(%#v, %#v)", c.expected, c.actual), func(t *testing.T) {
1027+
expectedEqualResult := !c.notEqualResult // EqualValues should return opposite of NotEqualValues
1028+
res := EqualValues(mockT, c.expected, c.actual)
1029+
1030+
if res != expectedEqualResult {
1031+
t.Errorf("EqualValues(%#v, %#v) should return %#v", c.expected, c.actual, expectedEqualResult)
10211032
}
10221033
})
10231034
}

0 commit comments

Comments
 (0)