Skip to content

Commit 83e2dae

Browse files
committed
Use the right method to get the expected error type.
1 parent 5d95b18 commit 83e2dae

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

assert/assertions.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2217,17 +2217,17 @@ func ErrorAs(t TestingT, err error, target interface{}, msgAndArgs ...interface{
22172217
return true
22182218
}
22192219

2220-
expectedText := reflect.ValueOf(target).Elem().Type().String()
2220+
expectedType := reflect.TypeOf(target).Elem().String()
22212221
if err == nil {
22222222
return Fail(t, fmt.Sprintf("An error is expected but got nil.\n"+
2223-
"expected: %s", expectedText), msgAndArgs...)
2223+
"expected: %s", expectedType), msgAndArgs...)
22242224
}
22252225

22262226
chain := buildErrorChainString(err, true)
22272227

22282228
return Fail(t, fmt.Sprintf("Should be in error chain:\n"+
22292229
"expected: %s\n"+
2230-
"in chain: %s", expectedText, chain,
2230+
"in chain: %s", expectedType, chain,
22312231
), msgAndArgs...)
22322232
}
22332233

@@ -2245,7 +2245,7 @@ func NotErrorAs(t TestingT, err error, target interface{}, msgAndArgs ...interfa
22452245

22462246
return Fail(t, fmt.Sprintf("Target error should not be in err chain:\n"+
22472247
"found: %s\n"+
2248-
"in chain: %s", reflect.ValueOf(target).Elem().Type(), chain,
2248+
"in chain: %s", reflect.TypeOf(target).Elem().String(), chain,
22492249
), msgAndArgs...)
22502250
}
22512251

0 commit comments

Comments
 (0)