Skip to content

Commit 7127b60

Browse files
ccoVeilledolmen
authored andcommitted
assert.ErrorAs: simplify retrieving the type name
1 parent 26b02e2 commit 7127b60

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

assert/assertions.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2225,17 +2225,17 @@ func ErrorAs(t TestingT, err error, target interface{}, msgAndArgs ...interface{
22252225
return true
22262226
}
22272227

2228-
expectedText := reflect.ValueOf(target).Elem().Type().String()
2228+
expectedType := reflect.TypeOf(target).Elem().String()
22292229
if err == nil {
22302230
return Fail(t, fmt.Sprintf("An error is expected but got nil.\n"+
2231-
"expected: %s", expectedText), msgAndArgs...)
2231+
"expected: %s", expectedType), msgAndArgs...)
22322232
}
22332233

22342234
chain := buildErrorChainString(err, true)
22352235

22362236
return Fail(t, fmt.Sprintf("Should be in error chain:\n"+
22372237
"expected: %s\n"+
2238-
"in chain: %s", expectedText, chain,
2238+
"in chain: %s", expectedType, chain,
22392239
), msgAndArgs...)
22402240
}
22412241

@@ -2253,7 +2253,7 @@ func NotErrorAs(t TestingT, err error, target interface{}, msgAndArgs ...interfa
22532253

22542254
return Fail(t, fmt.Sprintf("Target error should not be in err chain:\n"+
22552255
"found: %s\n"+
2256-
"in chain: %s", reflect.ValueOf(target).Elem().Type(), chain,
2256+
"in chain: %s", reflect.TypeOf(target).Elem().String(), chain,
22572257
), msgAndArgs...)
22582258
}
22592259

0 commit comments

Comments
 (0)