Fix battery string formatting #466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we use the old pattern in several widgets. Good to know that they should be updated. @streetturtle Do you prefer that to happen one at a time or all of them at once? (Depending on the answer we might need new issues - which could be Good First ones) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In modern versions of Lua, formatting a float with
%dis not allowed (see https://stackoverflow.com/questions/31577104/lua-format-string-cant-format-float-as-decimal-d-as-of-5-3). This PR fixes it by using%.0f. This technically changes the behavior because instead of truncating, it rounds the number, but there is no significant difference in my opinion.