style: Cosmetic fixes #141
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,3 +2,4 @@ data/ | |
| .idea | ||
| .env | ||
| certs/ | ||
| /chainlink_config/tempkeys | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -452,7 +452,7 @@ services: | |
| timeout: 10s | ||
| retries: 60 | ||
| chainlink: | ||
| container_name: streamr-dev-chainlink | ||
| image: smartcontract/chainlink:0.10.5 | ||
| ports: | ||
| - '6688:6688' | ||
|
|
@@ -478,7 +478,7 @@ services: | |
| timeout: 10s | ||
| retries: 60 | ||
| chainlink-external-adapter: | ||
| container_name: streamr-dev-chainlink-external-adapter | ||
|
There was a problem hiding this comment. this breaks the chainlink workflow because it is linked directly to the container, instead of 10.200.10.1. I created a ticket to fix this: https://linear.app/streamr/issue/ETH-155 |
||
| image: streamr/chainlink-external-adapter:dev | ||
| ports: | ||
| - 6691:8080 | ||
|
|
@@ -511,7 +511,6 @@ networks: | |
| volumes: | ||
| mysql_init_scripts: | ||
| cassandra_init_scripts: | ||
| data-bridge-data-rabbitmq: | ||
| data-bridge-data-redis: | ||
| data-mysql: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing these keys ( - I think, didn't test ist recently - ) might result in the chainlink node creating new ones, so it probably will not work with the preloaded addresses on the sidechain. The chainlink node wont have any funds on its new address and then can't create transactions. Unless these keys are also in the database file, shared to the chainlink container, then it might still work without these key files.
The crosschain chainlink e2e workflow needs to be tested without these files before removing them, I will try to do this today before my holiday...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samt1803 This isn't urgent, just like the title says