Skip to content
This repository was archived by the owner on Apr 1, 2024. It is now read-only.

Commit b8d53aa

Browse files
authored
[improve][cli] Remove cli unnecessary code (apache#22161)
1 parent 4effaa7 commit b8d53aa

File tree

5 files changed

+2
-8
lines changed

5 files changed

+2
-8
lines changed

pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
import org.apache.pulsar.client.api.MessageListener;
4848
import org.apache.pulsar.client.api.PulsarClient;
4949
import org.apache.pulsar.client.api.Schema;
50-
import org.apache.pulsar.client.api.SizeUnit;
5150
import org.apache.pulsar.client.api.SubscriptionInitialPosition;
5251
import org.apache.pulsar.client.api.SubscriptionType;
5352
import org.apache.pulsar.client.api.transaction.Transaction;
@@ -230,7 +229,6 @@ public static void main(String[] args) throws Exception {
230229
long testEndTime = startTime + (long) (arguments.testTime * 1e9);
231230

232231
ClientBuilder clientBuilder = PerfClientUtils.createClientBuilderFromArguments(arguments)
233-
.memoryLimit(arguments.memoryLimit, SizeUnit.BYTES)
234232
.enableTransaction(arguments.isEnableTransaction);
235233

236234
PulsarClient pulsarClient = clientBuilder.build();

pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@
6969
import org.apache.pulsar.client.api.ProducerBuilder;
7070
import org.apache.pulsar.client.api.PulsarClient;
7171
import org.apache.pulsar.client.api.PulsarClientException;
72-
import org.apache.pulsar.client.api.SizeUnit;
7372
import org.apache.pulsar.client.api.TypedMessageBuilder;
7473
import org.apache.pulsar.client.api.transaction.Transaction;
7574
import org.apache.pulsar.common.partition.PartitionedTopicMetadata;
@@ -513,7 +512,6 @@ private static void runProducer(int producerId,
513512

514513

515514
ClientBuilder clientBuilder = PerfClientUtils.createClientBuilderFromArguments(arguments)
516-
.memoryLimit(arguments.memoryLimit, SizeUnit.BYTES)
517515
.enableTransaction(arguments.isEnableTransaction);
518516

519517
client = clientBuilder.build();

pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceReader.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
import org.apache.pulsar.client.api.Reader;
4141
import org.apache.pulsar.client.api.ReaderBuilder;
4242
import org.apache.pulsar.client.api.ReaderListener;
43-
import org.apache.pulsar.client.api.SizeUnit;
4443
import org.apache.pulsar.client.impl.MessageIdImpl;
4544
import org.apache.pulsar.common.naming.TopicName;
4645
import org.apache.pulsar.common.util.FutureUtil;
@@ -141,7 +140,6 @@ public static void main(String[] args) throws Exception {
141140
};
142141

143142
ClientBuilder clientBuilder = PerfClientUtils.createClientBuilderFromArguments(arguments)
144-
.memoryLimit(arguments.memoryLimit, SizeUnit.BYTES)
145143
.enableTls(arguments.useTls);
146144

147145
PulsarClient pulsarClient = clientBuilder.build();

pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceTransaction.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@
5858
import org.apache.pulsar.client.api.PulsarClient;
5959
import org.apache.pulsar.client.api.PulsarClientException;
6060
import org.apache.pulsar.client.api.Schema;
61-
import org.apache.pulsar.client.api.SizeUnit;
6261
import org.apache.pulsar.client.api.SubscriptionInitialPosition;
6362
import org.apache.pulsar.client.api.SubscriptionType;
6463
import org.apache.pulsar.client.api.transaction.Transaction;
@@ -224,7 +223,6 @@ public static void main(String[] args)
224223
}
225224

226225
ClientBuilder clientBuilder = PerfClientUtils.createClientBuilderFromArguments(arguments)
227-
.memoryLimit(arguments.memoryLimit, SizeUnit.BYTES)
228226
.enableTransaction(!arguments.isDisableTransaction);
229227

230228
try (PulsarClient client = clientBuilder.build()) {

pulsar-testclient/src/test/java/org/apache/pulsar/testclient/PerfClientUtilsTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ public void testClientCreation() throws Exception {
7070
args.tlsTrustCertsFilePath = "path";
7171
args.tlsAllowInsecureConnection = true;
7272
args.maxLookupRequest = 100000;
73+
args.memoryLimit = 10240;
7374

7475
final ClientBuilderImpl builder = (ClientBuilderImpl)PerfClientUtils.createClientBuilderFromArguments(args);
7576
final ClientConfigurationData conf = builder.getClientConfigurationData();
@@ -89,6 +90,7 @@ public void testClientCreation() throws Exception {
8990
Assert.assertEquals(conf.getMaxLookupRequest(), 100000);
9091
Assert.assertNull(conf.getProxyServiceUrl());
9192
Assert.assertNull(conf.getProxyProtocol());
93+
Assert.assertEquals(conf.getMemoryLimitBytes(), 10240L);
9294

9395
}
9496

0 commit comments

Comments
 (0)