Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

ISSUE-1369: Handle too_many_requests gracefully #87

Open
sijie opened this issue Jan 15, 2020 · 0 comments
Open

ISSUE-1369: Handle too_many_requests gracefully #87

sijie opened this issue Jan 15, 2020 · 0 comments

Comments

@sijie
Copy link
Member

sijie commented Jan 15, 2020

Original Issue: apache#1369


FEATURE REQUEST

  1. Please describe the feature you are requesting.
    Add more policy to deal too_many_requests error

  2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?
    nice-to-have

  3. Provide any additional detail on your proposed use case for this feature.
    Currently BookKeeper client use general error dealing logic to handle error, including too_many_requests error sent from bookie. The handle logic is remaking ensemble with excluding 'failed' bookie, but this is unfriendly. For example, when the cluster is small, remaking action will fail and the ledger will be closed, and following add-request will throw error. Maybe we can add other handling error policy: retry connection to 'failed' bookie; block request when resource is limited(one case is when adding to previous 'failed' bookie fail again). And these two policy should be used after current handling logic, and we need to log some useful information, such blocking state when using blocking i/o. I know this blocking and retring 'failed' bookie logic may bring in difficulty to low-latency goal, although it bring some out-of-box more easy-using feature in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant