This repository has been archived by the owner on Apr 15, 2024. It is now read-only.
ISSUE-617: Split bookkeeper client into a separate maven module #22
Labels
Comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Original Issue: apache#617
JIRA: https://issues.apache.org/jira/browse/BOOKKEEPER-792
Reporter: Ivan Kelly @ivankelly
Right now, to include bookkeeper as a dependency, you need to include org.apache.bookkeeper:bookkeeper-server
This pulls in all the bookkeeper-server code, and all the server dependencies as well as the client. The server dependencies are larger than the client dependencies. For one thing, it pulls in jna and log4j which should never be pulled in from the client.
Comments from JIRA
Ivan Kelly 2014-10-13T16:12:44.295+0000
Patch renames a lot of files, so I'd like to get it in as soon as possible to avoid a nightmare rebase if other changes go in.
Hadoop QA 2014-10-13T16:47:35.965+0000
Testing JIRA BOOKKEEPER-792
Patch [0001-Split-the-bookkeeper-client-from-the-server.patch|https://issues.apache.org/jira/secure/attachment/12674526/0001-Split-the-bookkeeper-client-from-the-server.patch] downloaded at Mon Oct 13 16:20:56 UTC 2014
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:red}-1 FINDBUGS{color}
. {color:red}-1{color} the patch seems to introduce 23 new Findbugs warning(s) in module(s) [bookkeeper-client]
{color:red}-1 TESTS{color}
. Tests run: 1113
. Tests failed: 191
. Tests errors: 202
. The patch failed the following testcases:
. testScanMessagesOnUnclosedLedgerAfterDeleteLedger0
. testScanMessagesOnEmptyLedgerAfterDeleteLedger0
. testFailedToDeleteLedger10
. testFailedToDeleteLedger20
. testScanMessagesOnTwoLedgers0
. testInconsistentSubscriptionStateAndLedgerRanges10
. testInconsistentSubscriptionStateAndLedgerRanges20
. testReadWhenTopicChangeLedger0
. testScanMessagesOnClosedLedgerAfterDeleteLedger1
. testScanMessagesOnUnclosedLedgerAfterDeleteLedger1
. testScanMessagesOnEmptyLedgerAfterDeleteLedger1
. testFailedToDeleteLedger11
. testFailedToDeleteLedger21
. testScanMessagesOnTwoLedgers1
. testInconsistentSubscriptionStateAndLedgerRanges11
. testInconsistentSubscriptionStateAndLedgerRanges21
. testReadWhenTopicChangeLedger1
. testAttachToSubscriptionSuccess0
. testServerRedirect0
. testSubscribeAndConsume0
. testServerFailoverPublishOnly0
. testServerFailover0
. testUnsubscribe0
. testSyncUnsubscribeWithoutSubscription0
. testAsyncUnsubscribeWithoutSubscription0
. testCloseSubscription0
. testStartDeliveryTwice0
. testStopDelivery0
. testConsumedMessagesInOrder0
. testCreateSubscriptionFailure0
. testCreateSubscriptionSuccess0
. testAttachToSubscriptionFailure0
. testSyncSubscribeWithInvalidSubscriberId0
. testAsyncSubscribeWithInvalidSubscriberId0
. testSyncUnsubscribeWithInvalidSubscriberId0
. testAsyncUnsubscribeWithInvalidSubscriberId0
. testSyncHubSubscribeWithInvalidSubscriberId0
. testAsyncHubSubscribeWithInvalidSubscriberId0
. testSyncHubUnsubscribeWithInvalidSubscriberId0
. testAsyncHubUnsubscribeWithInvalidSubscriberId0
. testPublishWithBookKeeperError0
. testManualConsumeClient1
. testAttachToSubscriptionSuccess1
. testServerRedirect1
. testSubscribeAndConsume1
. testServerFailoverPublishOnly1
. testServerFailover1
. testUnsubscribe1
. testSyncUnsubscribeWithoutSubscription1
. testAsyncUnsubscribeWithoutSubscription1
. testCloseSubscription1
. testStartDeliveryTwice1
. testStopDelivery1
. testConsumedMessagesInOrder1
. testCreateSubscriptionFailure1
. testCreateSubscriptionSuccess1
. testAttachToSubscriptionFailure1
. testSyncSubscribeWithInvalidSubscriberId1
. testAsyncSubscribeWithInvalidSubscriberId1
. testSyncUnsubscribeWithInvalidSubscriberId1
. testAsyncUnsubscribeWithInvalidSubscriberId1
. testSyncHubSubscribeWithInvalidSubscriberId1
. testAsyncHubSubscribeWithInvalidSubscriberId1
. testSyncHubUnsubscribeWithInvalidSubscriberId1
. testAsyncHubUnsubscribeWithInvalidSubscriberId1
. testPublishWithBookKeeperError1
. testCloseSubscription(org.apache.hedwig.client.netty.TestMultiplexing)
. testThrottle(org.apache.hedwig.client.netty.TestMultiplexing)
. testAttachToSubscriptionSuccess0
. testServerRedirect0
. testSubscribeAndConsume0
. testServerFailoverPublishOnly0
. testServerFailover0
. testUnsubscribe0
. testSyncUnsubscribeWithoutSubscription0
. testAsyncUnsubscribeWithoutSubscription0
. testCloseSubscription0
. testStartDeliveryTwice0
. testStopDelivery0
. testConsumedMessagesInOrder0
. testCreateSubscriptionFailure0
. testCreateSubscriptionSuccess0
. testAttachToSubscriptionFailure0
. testSyncSubscribeWithInvalidSubscriberId0
. testAsyncSubscribeWithInvalidSubscriberId0
. testSyncUnsubscribeWithInvalidSubscriberId0
. testAsyncUnsubscribeWithInvalidSubscriberId0
. testSyncHubSubscribeWithInvalidSubscriberId0
. testAsyncHubSubscribeWithInvalidSubscriberId0
. testSyncHubUnsubscribeWithInvalidSubscriberId0
. testAsyncHubUnsubscribeWithInvalidSubscriberId0
. testPublishWithBookKeeperError0
. testManualConsumeClient1
. testAttachToSubscriptionSuccess1
. testServerRedirect1
. testSubscribeAndConsume1
. testServerFailoverPublishOnly1
. testServerFailover1
. testUnsubscribe1
. testSyncUnsubscribeWithoutSubscription1
. testAsyncUnsubscribeWithoutSubscription1
. testCloseSubscription1
. testStartDeliveryTwice1
. testStopDelivery1
. testConsumedMessagesInOrder1
. testCreateSubscriptionFailure1
. testCreateSubscriptionSuccess1
. testAttachToSubscriptionFailure1
. testSyncSubscribeWithInvalidSubscriberId1
. testAsyncSubscribeWithInvalidSubscriberId1
. testSyncUnsubscribeWithInvalidSubscriberId1
. testAsyncUnsubscribeWithInvalidSubscriberId1
. testSyncHubSubscribeWithInvalidSubscriberId1
. testAsyncHubSubscribeWithInvalidSubscriberId1
. testSyncHubUnsubscribeWithInvalidSubscriberId1
. testAsyncHubUnsubscribeWithInvalidSubscriberId1
. testPublishWithBookKeeperError1
. testNonEmptyDirtyLedger(org.apache.hedwig.server.persistence.TestBookkeeperPersistenceManagerWhiteBox)
. testSyncChangeLedgers(org.apache.hedwig.server.persistence.TestBookkeeperPersistenceManagerWhiteBox)
. testAsyncChangeLedgers(org.apache.hedwig.server.persistence.TestBookkeeperPersistenceManagerWhiteBox)
. testChangeLedgerFailure(org.apache.hedwig.server.persistence.TestBookkeeperPersistenceManagerWhiteBox)
. testThrottleWithServerSideFilter0
. testServerSideThrottle1
. testThrottleWithServerSideFilter1
. testConsumeWhenHubShutdown(org.apache.hedwig.server.subscriptions.TestUpdateSubscriptionState)
. testAttachToSubscriptionSuccess0
. testServerRedirect0
. testSubscribeAndConsume0
. testServerFailoverPublishOnly0
. testServerFailover0
. testUnsubscribe0
. testSyncUnsubscribeWithoutSubscription0
. testAsyncUnsubscribeWithoutSubscription0
. testCloseSubscription0
. testStartDeliveryTwice0
. testStopDelivery0
. testConsumedMessagesInOrder0
. testCreateSubscriptionFailure0
. testCreateSubscriptionSuccess0
. testAttachToSubscriptionFailure0
. testSyncSubscribeWithInvalidSubscriberId0
. testAsyncSubscribeWithInvalidSubscriberId0
. testSyncUnsubscribeWithInvalidSubscriberId0
. testAsyncUnsubscribeWithInvalidSubscriberId0
. testSyncHubSubscribeWithInvalidSubscriberId0
. testAsyncHubSubscribeWithInvalidSubscriberId0
. testSyncHubUnsubscribeWithInvalidSubscriberId0
. testAsyncHubUnsubscribeWithInvalidSubscriberId0
. testPublishWithBookKeeperError0
. testManualConsumeClient1
. testAttachToSubscriptionSuccess1
. testServerRedirect1
. testSubscribeAndConsume1
. testServerFailoverPublishOnly1
. testServerFailover1
. testUnsubscribe1
. testSyncUnsubscribeWithoutSubscription1
. testAsyncUnsubscribeWithoutSubscription1
. testCloseSubscription1
. testStartDeliveryTwice1
. testStopDelivery1
. testConsumedMessagesInOrder1
. testCreateSubscriptionFailure1
. testCreateSubscriptionSuccess1
. testAttachToSubscriptionFailure1
. testSyncSubscribeWithInvalidSubscriberId1
. testAsyncSubscribeWithInvalidSubscriberId1
. testSyncUnsubscribeWithInvalidSubscriberId1
. testAsyncUnsubscribeWithInvalidSubscriberId1
. testSyncHubSubscribeWithInvalidSubscriberId1
. testAsyncHubSubscribeWithInvalidSubscriberId1
. testSyncHubUnsubscribeWithInvalidSubscriberId1
. testAsyncHubUnsubscribeWithInvalidSubscriberId1
. testPublishWithBookKeeperError1
. testInvalidServerSideMessageFilter(org.apache.hedwig.server.filter.TestMessageFilter)
. testChangeSubscriptionPreferences(org.apache.hedwig.server.filter.TestMessageFilter)
. testChangeServerSideMessageFilter(org.apache.hedwig.server.filter.TestMessageFilter)
. testFixInvalidServerSideMessageFilter(org.apache.hedwig.server.filter.TestMessageFilter)
. testNullClientMessageFilter(org.apache.hedwig.server.filter.TestMessageFilter)
. testClientSideMessageFilter(org.apache.hedwig.server.filter.TestMessageFilter)
. testChangeSubscriptionPreferencesForClientFilter(org.apache.hedwig.server.filter.TestMessageFilter)
. testChangeClientSideMessageFilter(org.apache.hedwig.server.filter.TestMessageFilter)
. testSimpleClientDoesntGetTopicBusy(org.apache.hedwig.client.TestSubAfterCloseSub)
. testSubscribeAndConsumeWhenARegionDown0
. testAttachExistingSubscriptionsWhenARegionDown0
. testMultiRegionSubscribeAndConsume1
. testSubscribeAndConsumeWhenARegionDown1
. testAttachExistingSubscriptionsWhenARegionDown1
. testMultipleSubscribers(org.apache.hedwig.server.persistence.MessageBoundedPersistenceTest)
. testUpdateMessageBound(org.apache.hedwig.server.persistence.MessageBoundedPersistenceTest)
. testLedgerGC(org.apache.hedwig.server.persistence.MessageBoundedPersistenceTest)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:red}-1 Overall result, please check the reported -1(s){color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/779/
Ivan Kelly 2014-10-13T17:14:53.479+0000
Fixed findbugs issue (excludes was missing for protobuf files). Also removed shading in bookkeeper-server, as that was causing problems in the tests. I plan to create another jira to create another module (bookkeeper-client-bigjar) which has all dependencies shaded, so that anyone with conflicts can pull that version in and people without conflicts can use the smaller bookkeeper-client dependency.
Hadoop QA 2014-10-13T17:53:25.866+0000
Testing JIRA BOOKKEEPER-792
Patch [0001-Split-the-bookkeeper-client-from-the-server.patch|https://issues.apache.org/jira/secure/attachment/12674541/0001-Split-the-bookkeeper-client-from-the-server.patch] downloaded at Mon Oct 13 17:20:55 UTC 2014
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:red}-1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:red}-1{color} the patch seems to introduce 1 new javac warning(s)
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:green}+1 TESTS{color}
. Tests run: 929
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:red}-1 Overall result, please check the reported -1(s){color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/780/
Hadoop QA 2014-10-13T20:23:26.719+0000
Testing JIRA BOOKKEEPER-792
Patch [0001-Split-the-bookkeeper-client-from-the-server.patch|https://issues.apache.org/jira/secure/attachment/12674541/0001-Split-the-bookkeeper-client-from-the-server.patch] downloaded at Mon Oct 13 19:50:59 UTC 2014
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:red}-1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:red}-1{color} the patch seems to introduce 1 new javac warning(s)
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:green}+1 TESTS{color}
. Tests run: 929
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:red}-1 Overall result, please check the reported -1(s){color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/781/
Hadoop QA 2014-10-13T22:33:52.830+0000
Testing JIRA BOOKKEEPER-792
Patch [0001-Split-the-bookkeeper-client-from-the-server.patch|https://issues.apache.org/jira/secure/attachment/12674541/0001-Split-the-bookkeeper-client-from-the-server.patch] downloaded at Mon Oct 13 22:01:02 UTC 2014
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:red}-1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:red}-1{color} the patch seems to introduce 1 new javac warning(s)
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:green}+1 TESTS{color}
. Tests run: 929
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:red}-1 Overall result, please check the reported -1(s){color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/782/
Hadoop QA 2014-10-14T01:09:37.768+0000
Testing JIRA BOOKKEEPER-792
Patch [0001-Split-the-bookkeeper-client-from-the-server.patch|https://issues.apache.org/jira/secure/attachment/12674541/0001-Split-the-bookkeeper-client-from-the-server.patch] downloaded at Tue Oct 14 00:36:40 UTC 2014
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:red}-1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:red}-1{color} the patch seems to introduce 1 new javac warning(s)
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:green}+1 TESTS{color}
. Tests run: 929
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:red}-1 Overall result, please check the reported -1(s){color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/785/
Hadoop QA 2014-10-14T06:56:25.861+0000
Testing JIRA BOOKKEEPER-792
Patch [0001-Split-the-bookkeeper-client-from-the-server.patch|https://issues.apache.org/jira/secure/attachment/12674541/0001-Split-the-bookkeeper-client-from-the-server.patch] downloaded at Tue Oct 14 06:23:39 UTC 2014
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:red}-1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:red}-1{color} the patch seems to introduce 1 new javac warning(s)
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:green}+1 TESTS{color}
. Tests run: 929
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:red}-1 Overall result, please check the reported -1(s){color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/789/
Ivan Kelly 2014-10-14T10:49:46.380+0000
Not actually a javac warning, but the license thing looking for a dependency-reduce-pom.xml that doesn't exist anymore. Will be added back when I add the fatjar module.
Hadoop QA 2014-10-14T11:23:47.409+0000
Testing JIRA BOOKKEEPER-792
Patch [0001-Split-the-bookkeeper-client-from-the-server.patch|https://issues.apache.org/jira/secure/attachment/12674744/0001-Split-the-bookkeeper-client-from-the-server.patch] downloaded at Tue Oct 14 10:50:56 UTC 2014
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:green}+1 TESTS{color}
. Tests run: 929
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:red}-1 Overall result, please check the reported -1(s){color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/790/
Hadoop QA 2014-10-14T12:59:40.711+0000
Testing JIRA BOOKKEEPER-792
Patch [0001-Split-the-bookkeeper-client-from-the-server.patch|https://issues.apache.org/jira/secure/attachment/12674744/0001-Split-the-bookkeeper-client-from-the-server.patch] downloaded at Tue Oct 14 12:26:50 UTC 2014
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:green}+1 TESTS{color}
. Tests run: 929
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:red}-1 Overall result, please check the reported -1(s){color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/792/
Sijie Guo 2014-10-15T05:37:10.729+0000
I just have one concern how we commit this. How we could keep the history of those moved files?
Sijie Guo 2014-10-15T05:44:14.340+0000
BTW, did you config your git to detect renames (diff.renames=true)? could you also put your patch onto review board, otherwise it is hard to track what files moved and what files are modified.
Ivan Kelly 2014-10-20T15:48:57.412+0000
I didn't. Currently in the middle of a massive rebase, so don't want to switch branches right now to check. In any case, though, submitting to subversion would lose the rename. Perhaps it would be better to wait until we've moved to git (as part of TLP) to do this.
Hadoop QA 2014-10-22T03:04:23.574+0000
Testing JIRA BOOKKEEPER-792
Patch [0001-Split-the-bookkeeper-client-from-the-server.patch|https://issues.apache.org/jira/secure/attachment/12674744/0001-Split-the-bookkeeper-client-from-the-server.patch] downloaded at Wed Oct 22 02:31:00 UTC 2014
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:red}-1 TESTS{color}
. Tests run: 929
. Tests failed: 1
. Tests errors: 0
. The patch failed the following testcases:
. testSimpleChat(org.apache.hedwig.jms.BasicJMSTest)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:red}-1 Overall result, please check the reported -1(s){color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/799/
Hadoop QA 2014-10-23T21:09:17.536+0000
Testing JIRA BOOKKEEPER-792
Patch [0001-Split-the-bookkeeper-client-from-the-server.patch|https://issues.apache.org/jira/secure/attachment/12674744/0001-Split-the-bookkeeper-client-from-the-server.patch] downloaded at Thu Oct 23 20:36:00 UTC 2014
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:green}+1 TESTS{color}
. Tests run: 929
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:red}-1 Overall result, please check the reported -1(s){color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/802/
Hadoop QA 2014-10-24T00:38:05.275+0000
Testing JIRA BOOKKEEPER-792
Patch [0001-Split-the-bookkeeper-client-from-the-server.patch|https://issues.apache.org/jira/secure/attachment/12674744/0001-Split-the-bookkeeper-client-from-the-server.patch] downloaded at Fri Oct 24 00:04:42 UTC 2014
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:green}+1 TESTS{color}
. Tests run: 929
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:red}-1 Overall result, please check the reported -1(s){color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/803/
Hadoop QA 2014-11-04T01:47:05.141+0000
Testing JIRA BOOKKEEPER-792
Patch [0001-Split-the-bookkeeper-client-from-the-server.patch|https://issues.apache.org/jira/secure/attachment/12674744/0001-Split-the-bookkeeper-client-from-the-server.patch] downloaded at Tue Nov 4 01:13:45 UTC 2014
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:red}-1 TESTS{color}
. Tests run: 929
. Tests failed: 1
. Tests errors: 0
. The patch failed the following testcases:
. testSimpleChat(org.apache.hedwig.jms.BasicJMSTest)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:red}-1 Overall result, please check the reported -1(s){color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/808/
Ivan Kelly 2014-11-10T16:34:03.187+0000
Cancelling until we move to git, so we can track renames better.
Sijie Guo 2017-06-22T00:31:02.435+0000
Move this to 4.6.0.
The text was updated successfully, but these errors were encountered: