Add test setup for each component #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pbelczyk
changed the title
sfc-gh-pbelczyk
force-pushed
the
STREAMLIT-3894-duplicate-e2e-setup-for-all-examples-and-components
branch
from
cb65182 to
ebfae49
Compare
sfc-gh-gpijanski
approved these changes
Aug 18, 2023
| # "name" argument without having it get recreated. | ||
| name_input = st.text_input("Enter a name", value="Streamlit") | ||
| num_clicks = my_component(name_input, key="foo") | ||
| st.markdown("You've clicked %s times!" % int(num_clicks)) |
Contributor
There was a problem hiding this comment.
Do we need to update the component guide now?
|
|
||
|
|
||
| def _find_free_port(): | ||
| with closing(socket.socket(socket.AF_INET, socket.SOCK_STREAM)) as s: |
Contributor
There was a problem hiding this comment.
It would be great if the code in our templates had more docstrings. For each method you can write something to make the code easier to use. We should also type hints.
Contributor
Author
There was a problem hiding this comment.
If it's ok I will do this in all utils files sync PR
sfc-gh-kbregula
approved these changes
Aug 22, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add simple test case and setup for each component and template.