Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyboardjs is loaded async, while useKeyPress is already trying to access it #103

Closed
jacargentina opened this issue Feb 8, 2019 · 3 comments · Fixed by #110
Closed

keyboardjs is loaded async, while useKeyPress is already trying to access it #103

jacargentina opened this issue Feb 8, 2019 · 3 comments · Fixed by #110
Labels
released

Comments

@jacargentina
Copy link

I 've stuck with this, attached stack trace.

captura de pantalla 2019-02-08 a la s 14 46 55

Originating here:

captura de pantalla 2019-02-08 a la s 14 50 16

KeyboardJS loading is like this:

captura de pantalla 2019-02-08 a la s 14 51 40
@jacargentina
Copy link
Author

@streamich can you look? this is not letting me use this fantastic library, i dont want to install more deps please! 🙏

streamich added a commit that referenced this issue Feb 19, 2019
@streamich
fix: 🐛 better async loading for keyboardjs
2096bae 
closes #103
@streamich streamich mentioned this issue Feb 19, 2019
Merged
@streamich
Copy link
Owner

@jacargentina This might solve it: #110

streamich pushed a commit that referenced this issue Feb 19, 2019
@semantic-release-bot
chore(release): 5.4.1 [skip ci]
4552ee0 
## [5.4.1](v5.4.0...v5.4.1) (2019-02-19)

### Bug Fixes

* 🐛 better async loading for keyboardjs ([2096bae](2096bae)), closes [#103](#103)
@streamich
Copy link
Owner

🎉 This issue has been resolved in version 5.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 better async loading for keyboardjs streamich/react-use
2 participants
@jacargentina @streamich