fix: 🐛 don't throw only in development

Throwing changes behaviour of the code, other code may rely on this behaviour, so we either throw in all environments or console.error instead. BREAKING CHANGE: 🧨 error is logged instead of thrown in development environment
streamich · Mar 26, 2019 · f5faba5 · f5faba5 · deevus · Apr 5, 2019
1 parent 2b3dd23
commit f5faba5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/useGetSetState.ts b/src/useGetSetState.ts
@@ -4,7 +4,7 @@ import useUpdate from './useUpdate';
 const useGetSetState = <T extends object>(initialState: T = {} as T): [() => T, (patch: Partial<T>) => void]=> {
   if (process.env.NODE_ENV !== 'production') {
     if (typeof initialState !== 'object') {
-      throw new TypeError('useGetSetState initial state must be an object.');
+      console.error('useGetSetState initial state must be an object.');
     }
   }
 
@@ -15,7 +15,7 @@ const useGetSetState = <T extends object>(initialState: T = {} as T): [() => T,
     if (!patch) return;
     if (process.env.NODE_ENV !== 'production') {
       if (typeof patch !== 'object') {
-        throw new TypeError('useGetSetState setter patch must be an object.');
+        console.error('useGetSetState setter patch must be an object.');
       }
     }
     Object.assign(state.current, patch);

diff --git a/src/useHoverDirty.ts b/src/useHoverDirty.ts
@@ -4,7 +4,7 @@ import {useEffect, useState} from 'react';
 const useHoverDirty = (ref, enabled: boolean = true) => {
   if (process.env.NODE_ENV === 'development') {
     if ((typeof ref !== 'object') || (typeof ref.current === 'undefined')) {
-      throw new TypeError('useHoverDirty expects a single ref argument.');
+      console.error('useHoverDirty expects a single ref argument.');
     }
   }
 

diff --git a/src/useMouse.ts b/src/useMouse.ts
@@ -15,7 +15,7 @@ export interface State {
 const useMouse = (ref: RefObject<HTMLElement>, whenHovered: boolean = false): State => {
   if (process.env.NODE_ENV === 'development') {
     if ((typeof ref !== 'object') || (typeof ref.current === 'undefined')) {
-      throw new TypeError('useMouse expects a single ref argument.');
+      console.error('useMouse expects a single ref argument.');
     }
   }
	const useMouse = (ref: RefObject<HTMLElement>): State => {
	if (process.env.NODE_ENV === 'development') {
	if ((typeof ref !== 'object') \|\| (typeof ref.current === 'undefined')) {
	console.error('useMouse expects a single ref argument.');
	}
	}
	const useFullscreen = (ref: RefObject<Element>, on: boolean, options: FullScreenOptions = {}): boolean => {
	const {video, onClose = noop} = options;
	const [isFullscreen, setIsFullscreen] = useState(on);

	useLayoutEffect(() => {
	if (!on) return;
	if (!ref.current) return;