Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation of the Left & Right Hotkey Actions - Left Shift, Etc. #19

Open
H3r3t1x opened this issue Mar 10, 2021 · 6 comments
Open

Separation of the Left & Right Hotkey Actions - Left Shift, Etc. #19

H3r3t1x opened this issue Mar 10, 2021 · 6 comments
Labels
Community Submission Used for Issues created by anyone who is not a Stream-Pi Team Member Hotkey Action New Feature New Feature Request

Comments

@H3r3t1x
Copy link

H3r3t1x commented Mar 10, 2021

Example: Left and Right SHIFT cannot be specified in the Hotkey Action. Certain programs only see one or the other.

@TOGLK
Copy link

TOGLK commented Mar 10, 2021

Example: Left and Right SHIFT cannot be specified in the Hotkey Action. Certain programs only see one or the other.

Can I suggest the following Adjustments to your Issue:

Change Of Title to:

[Cross-Platform] [Feature Request] [Hotkey Action] Separation of the Left & Right Hotkey Actions - Left Shift, Etc.

Adjustment to content of the issue to state the following:

Target Platform:
Cross-Platform

Is this a Bug-Fix, Feature Request, or, Other?:
Feature Request

Describe the Issue:
Currently the "Hotkey" Action within Stream-Pi see's all "CTRL", "SHIFT", &, "META"/"WINDOWS" keys as just singular
keys and it does not take into the account the fact that most keyboards have clearly defined "Left" & "Right" bias's to each
of those key set's, AND, As a result of that many programs need to have either the "Left" or "Right" key bias's defined.

What Solution do you suggest to Resolve the Issue?:
Currently the simplest solution, and the most obvious, is to add additional Hotkey definitions for the following keyboard
inputs; "LEFT SHIFT", "RIGHT SHIFT", "LEFT CTRL", "RIGHT CTRL", "LEFT META"/"LEFT WINDOWS", "RIGHT
META"/"RIGHT WINDOWS".

@rnayabed
Copy link
Member

I think javafx.scene.robot.Robot needs to replaced and something other than that should be used for hotkeys. I will try to phase it out in favor of xdotool for linux/MacOS, and classic Win32 SendInput for Windows.

@rnayabed
Copy link
Member

This is because Robot seems very limited. There are no Left shift or right shift it seems

@rnayabed rnayabed changed the title Separate Left and Right hotkey actions [Cross-Platform] [Feature Request] [Hotkey Action] Separation of the Left & Right Hotkey Actions - Left Shift, Etc. Mar 10, 2021
@H3r3t1x
Copy link
Author

H3r3t1x commented Mar 10, 2021

@TOGLK Are you asking me to format it like that in the future? I will do my best to describe issues in as much detail as I can but I am not a programmer. My descriptions will be in much simpler terms.

@TOGLK
Copy link

TOGLK commented Mar 10, 2021

@TOGLK Are you asking me to format it like that in the future? I will do my best to describe issues in as much detail as I can but I am not a programmer. My descriptions will be in much simpler terms.

It is okay, I am not a programmer either.
It is just for formalities sake, it keeps things easier for external viewers and potential contributors to track.

I have laid out the format above as clearly as I can in this case, but with your feedback in mind I will try to type up a template that you, and others, can follow in the future with a simple use of copying & pasting for the most part to reduce time spent creating new issues which can be boring.

If their is any particular features you'd like me to add to the template then feel free to contact me via the Stream-Pi Discord and I'll do my best to apply such changes in lieu.

@H3r3t1x
Copy link
Author

H3r3t1x commented Mar 11, 2021

That sounds great. Thank you for clarifying.

@j4ckofalltrades j4ckofalltrades added Community Submission Used for Issues created by anyone who is not a Stream-Pi Team Member New Feature New Feature Request Hotkey Action labels Jun 25, 2021
@j4ckofalltrades j4ckofalltrades changed the title [Cross-Platform] [Feature Request] [Hotkey Action] Separation of the Left & Right Hotkey Actions - Left Shift, Etc. Separation of the Left & Right Hotkey Actions - Left Shift, Etc. Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Submission Used for Issues created by anyone who is not a Stream-Pi Team Member Hotkey Action New Feature New Feature Request
Projects
None yet
Development

No branches or pull requests

4 participants