Skip to content

Commit 133a26c

Browse files
ezio-melottibrettcannon
authored andcommitted
Handling of generated files after migrated to Github (python#138)
1 parent 6450775 commit 133a26c

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

setup.rst

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -303,20 +303,18 @@ functionality (such as using a new system call), it is necessary to update the
303303
Python's ``configure`` script is generated from ``configure.ac`` using Autoconf.
304304
Instead of editing ``configure``, edit ``configure.ac`` and then run
305305
``autoreconf`` to regenerate ``configure`` and a number of other files (such as
306-
``pyconfig.h``.
306+
``pyconfig.h``).
307307

308-
When submitting a patch with changes made to ``configure.ac``, it is preferred
309-
to leave out the generated files as differences between Autoconf versions
310-
frequently results in many spurious changes cluttering the patch. Instead,
311-
remind any potential reviewers on the tracker to run ``autoreconf``.
308+
When submitting a patch with changes made to ``configure.ac``, you should also
309+
include the generated files.
312310

313311
Note that running ``autoreconf`` is not the same as running ``autoconf``. For
314312
example, ``autoconf`` by itself will not regenerate ``pyconfig.h.in``.
315313
``autoreconf`` runs ``autoconf`` and a number of other tools repeatedly as is
316314
appropriate.
317315

318316
Python's ``configure.ac`` script typically requires a specific version of
319-
Autoconf. At the moment, this reads: ``version_required(2.65)``
317+
Autoconf. At the moment, this reads: ``AC_PREREQ(2.65)``.
320318

321319
If the system copy of Autoconf does not match this version, you will need to
322320
install your own copy of Autoconf.

0 commit comments

Comments
 (0)