Open
Conversation
Signed-off-by: Andrew Bone <AndrewB05@gmail.com>
addMenuLink['Component'] expects
```tsx
() => Promise<{
default: React.ComponentType;
}>;
```
Meaning the component must be the default export
Signed-off-by: Andrew Bone <AndrewB05@gmail.com>
|
- Use the `StrapiAppPlugin` type rather than remaking it - fix registerTrads so it actually transforms languages. Signed-off-by: Andrew Bone <AndrewB05@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What does it do?
Remove the
anyfrom register and update the function so it matches the existing type.One of the changes is to make App a default export, this is simply to make the linter happy and changing the type might be the correct way to go.
Why is it needed?
Types are good
How to test it?
Load the types in and see the linter is happy.
Related issue(s)/PR(s)
N/A
Edit:
I noticed there was already a type the describes this whole export so I've set it up to use that instead.
While I was in there I realised the mapping of translation keys wasn't happening so I've added that in.
Let me know if yo need that to be a send PR.