-
Notifications
You must be signed in to change notification settings - Fork 151
ci: add workflows verifying compatibility with tools, docs, and agent… #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
run: | | ||
cd agent-builder | ||
|
||
sed -i "s|.*strands-agents\[ollama\].*|\"strands-agents[ollama] @ file://${GITHUB_WORKSPACE}/sdk-python\",|" pyproject.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of updating the pyproject.toml, should we just add another target for pulling a local install?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean something like the following in the tools repo
[tool.hatch.envs.test]
dependencies = [
"strands-agents[ollama] @ file://${GITHUB_WORKSPACE}/sdk-python",
]
I thought about this but it leaves the workflow specific test logic in the pyproject which seemed odd to me. I can update if you think thats better than hiding the oddness in the workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to see if I can do this with an env var actually
Description
This PR adds three new GitHub workflow files to verify compatibility across the strands-agents ecosystem:
verify-agent-builder-compatibility.yml
: Tests compatibility betweensdk-python
and the agent-builder repositoryverify-docs-compatibility.yml
: Ensuressdk-python
works correctly with the documentation build processverify-tools-compatibility.yml
: Validates compatibility betweensdk-python
and the tools repositoryAll workflows:
These workflows will help maintain compatibility across the ecosystem and catch potential breaking changes early in the development process.
Related Issues
N/A
Documentation PR
No documentation is needed for this PR.
Type of Change
Testing
[How have you tested the change?]
hatch fmt --linter
hatch fmt --formatter
hatch test --all
Changes have been verified on the https://github.com/dbschmigelski/sdk-python fork. The fork
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.