Skip to content

ci: add workflows verifying compatibility with tools, docs, and agent… #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dbschmigelski
Copy link
Member

Description

This PR adds three new GitHub workflow files to verify compatibility across the strands-agents ecosystem:

verify-agent-builder-compatibility.yml: Tests compatibility between sdk-python and the agent-builder repository
verify-docs-compatibility.yml: Ensures sdk-python works correctly with the documentation build process
verify-tools-compatibility.yml: Validates compatibility between sdk-python and the tools repository

All workflows:

  • Run on pull requests and pushes to main branch
  • Test against Python versions 3.10, 3.11, 3.12, and 3.13
  • Because tests are executed using hatch, the workflows override the dependencies in the pyproject.toml since hatch will create its own isolated env

These workflows will help maintain compatibility across the ecosystem and catch potential breaking changes early in the development process.

Related Issues

N/A

Documentation PR

No documentation is needed for this PR.

Type of Change

  • Other (please describe): Improving CI

Testing

[How have you tested the change?]

  • hatch fmt --linter
  • hatch fmt --formatter
  • hatch test --all
  • Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

Changes have been verified on the https://github.com/dbschmigelski/sdk-python fork. The fork

Checklist

  • I have read the CONTRIBUTING document
  • I have added tests that prove my fix is effective or my feature works
  • [n/a] I have updated the documentation accordingly
  • [n/a] I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dbschmigelski dbschmigelski requested a review from a team as a code owner May 19, 2025 04:21
run: |
cd agent-builder

sed -i "s|.*strands-agents\[ollama\].*|\"strands-agents[ollama] @ file://${GITHUB_WORKSPACE}/sdk-python\",|" pyproject.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of updating the pyproject.toml, should we just add another target for pulling a local install?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean something like the following in the tools repo

[tool.hatch.envs.test]
dependencies = [
"strands-agents[ollama] @ file://${GITHUB_WORKSPACE}/sdk-python",
]

I thought about this but it leaves the workflow specific test logic in the pyproject which seemed odd to me. I can update if you think thats better than hiding the oddness in the workflow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to see if I can do this with an env var actually

@dbschmigelski dbschmigelski added the approved-for-integ-test Indicator that a pull request has been approved to run integration tests label Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-integ-test Indicator that a pull request has been approved to run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants