-
Notifications
You must be signed in to change notification settings - Fork 204
[REFACTOR] Unify Model Interface Around Single Entry Point (model.stream) #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…single entrypoint (model.stream)
pgrayy
reviewed
Jul 10, 2025
pgrayy
reviewed
Jul 10, 2025
zastrowm
reviewed
Jul 10, 2025
zastrowm
approved these changes
Jul 10, 2025
pgrayy
approved these changes
Jul 10, 2025
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Unify Model Interface Around Single Entry Point (model.stream)
Description
This PR refactors the model interface to use a unified, stream-first architecture that simplifies the model layer while maintaining external API compatibility.
Key Changes:
Interface Unification:
converse
/stream
pattern with unifiedstream
method as single entry pointstream
method signature to accept(messages, tool_specs, system_prompt)
directlyformat_request
andformat_chunk
methods from baseModel
classstream
implementationsImplementation Updates:
stream
methods (request formatting, invocation, completion)converse
method fromModel
base classTesting & Quality:
test_bedrock.py
to verify debug functionalityBenefits:
Related Issues
Documentation PR
Type of Change
Breaking change
Note: While this is technically a breaking change to the model interface, it maintains full backward compatibility for external consumers (Agent class, event loops, etc.)
Testing
How have you tested the change?
stream
method signature across all implementationshatch run prepare
Test Results:
Checklist