Skip to content

fix: add-threading-instrumentation #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

poshinchen
Copy link
Contributor

Description

We recently updated the agent calls with threading, this causes opentelemery fails to propagate context and result in creating multiple traceIds instead of one.

Adding opentelemetry-instrumentation-threading > ThreadingInstrumentor to allow context propagation between threads. And the package itself is pretty light so we can include them while installing the sdk-python.

Related Issues

NA

Documentation PR

NA

Type of Change

Bug fix

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare
  • Manually test the changes

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@poshinchen poshinchen requested a review from a team July 9, 2025 13:59
@poshinchen poshinchen marked this pull request as ready for review July 9, 2025 13:59
Copy link
Member

@awsarron awsarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add test coverage to ensure that this regression doesn't occur again in the future?

@poshinchen
Copy link
Contributor Author

Can we add test coverage to ensure that this regression doesn't occur again in the future?

I'll make it as follow-up!

@poshinchen poshinchen merged commit d423d92 into strands-agents:main Jul 9, 2025
12 of 22 checks passed
@poshinchen poshinchen self-assigned this Jul 9, 2025
malte-aws pushed a commit to malte-aws/sdk-python that referenced this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants