Skip to content

models - openai - do not accept b64 images #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

pgrayy
Copy link
Member

@pgrayy pgrayy commented Jul 7, 2025

Description

Following up on #251 to stop accepting base64 encoded images in the OpenAI model provider. For more details, see #252.

Related Issues

#252

Type of Change

  • Bug fix
  • New feature
  • Breaking change: This is intentional and was preceded by a log warning to users.
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pgrayy pgrayy temporarily deployed to auto-approve July 7, 2025 20:19 — with GitHub Actions Inactive
@pgrayy pgrayy requested a review from zastrowm July 7, 2025 20:20
@pgrayy pgrayy temporarily deployed to auto-approve July 7, 2025 20:24 — with GitHub Actions Inactive
@pgrayy pgrayy marked this pull request as ready for review July 7, 2025 20:24
Copy link
Member

@zastrowm zastrowm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update #253 with the recommended text/bullet-point for this breaking change. The last time we were gathering breaking-changes, it was up to the oncall to figure out the wordage, but ideally we'd be doing that as we go.

@pgrayy pgrayy merged commit 13cd76c into strands-agents:main Jul 7, 2025
12 of 22 checks passed
jsamuel1 pushed a commit to jsamuel1/sdk-python that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants