Skip to content

feat(telemetry): Expose OpenTelemetry exporter init arguments in API #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mrtj
Copy link

@mrtj mrtj commented Jul 7, 2025

Description

This PR enhances the StrandsTelemetry API by allowing users to pass arbitrary keyword arguments (**kwargs) directly to the constructors of OpenTelemetry's ConsoleSpanExporter and OTLPSpanExporter via the setup_console_exporter and setup_otlp_exporter methods. This exposes the full configuration surface of these exporters to downstream users, enabling more flexible and advanced telemetry setups. Docstrings have been updated to clarify this behavior. No breaking changes are introduced, and all setup methods remain chainable.

Related Issues

#363

Documentation PR

I am not sure how to update the docs

Type of Change

New feature

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mrtj mrtj requested a deployment to manual-approval July 7, 2025 14:12 — with GitHub Actions Waiting
Copy link
Member

@jer96 jer96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me. thank you for the contribution @mrtj

Copy link
Contributor

@poshinchen poshinchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the docs following the README: https://github.com/strands-agents/docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants