Skip to content

models - openai - async client #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

Conversation

pgrayy
Copy link
Member

@pgrayy pgrayy commented Jul 3, 2025

Description

Run the AsyncOpenAI client in our OpenAIModel provider.

Related Issues

#83

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare
  • Wrote new unit and integ tests.
  • Ran the following test script:
model = OpenAIModel({"api_key": "****"}, model_id="gpt-4o")
agent = Agent(model=model, callback_handler=None)

prompt = "What is 2+2? Think through the steps."


async def func_a():
    result = await agent.invoke_async(prompt)
    print(f"FUNC_A: {result.message}")


async def func_b():
    result = await agent.invoke_async(prompt)
    print(f"FUNC_B: {result.message}")


async def func_c():
    result = await agent.invoke_async(prompt)
    print(f"FUNC_C: {result.message}")


async def func_d():
    result = await agent.invoke_async(prompt)
    print(f"FUNC_D: {result.message}")


async def main():
    await asyncio.gather(func_a(), func_b(), func_c(), func_d())


asyncio.run(main())

Using the sync OpenAI Python client, every function ran sequentially and the total run time averaged 10s. Using the AsyncOpenAI Python client, every function ran concurrently and the total run time averaged 5s.

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pgrayy pgrayy temporarily deployed to auto-approve July 3, 2025 23:39 — with GitHub Actions Inactive
@pgrayy pgrayy marked this pull request as ready for review July 3, 2025 23:43
@pgrayy pgrayy merged commit 460adc9 into strands-agents:main Jul 7, 2025
22 checks passed
jsamuel1 pushed a commit to jsamuel1/sdk-python that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants