Extract hook based tests to a separate file #349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation: As I started adding new hook events, it started to become difficult to identify hook-based tests from general-purpose agent tests. To simplify things, I split out hook-related tests into
test_agent_hooks
.Also updated the hook tests verify each hook-event individually to be more readable/easier to debug.
The intention of the following format is to make it easier to understand as we add new hook-events:
when adding a new event, we sould increment the count but still keep the other events as-is:
Related Issues
#231
Documentation PR
N/A
Type of Change
Other: Refactor
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.