-
Notifications
You must be signed in to change notification settings - Fork 204
chore/update metrics #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
poshinchen
merged 1 commit into
strands-agents:main
from
poshinchen:chore/update-metrics
Jun 20, 2025
Merged
chore/update metrics #248
poshinchen
merged 1 commit into
strands-agents:main
from
poshinchen:chore/update-metrics
Jun 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2adf521
to
f361135
Compare
f361135
to
c478996
Compare
zastrowm
requested changes
Jun 19, 2025
c478996
to
1c98dfd
Compare
1c98dfd
to
1bbf7f4
Compare
zastrowm
previously approved these changes
Jun 20, 2025
1bbf7f4
to
25330fe
Compare
zastrowm
approved these changes
Jun 20, 2025
Unshure
pushed a commit
to Unshure/sdk-python
that referenced
this pull request
Jul 2, 2025
jsamuel1
pushed a commit
to jsamuel1/sdk-python
that referenced
this pull request
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Start emitting metrics in Strands to the collector if configured.
Documentation PR
Will add them once the exporter work is finished
Type of Change
Other (please describe):
Emit strands metrics
Testing
hatch run prepare
from opentelemetry import metrics
from opentelemetry.sdk.resources import Resource
from opentelemetry.sdk.metrics import MeterProvider
from opentelemetry.sdk.metrics.export import ConsoleMetricExporter, PeriodicExportingMetricReader
console_metric_reader = PeriodicExportingMetricReader(ConsoleMetricExporter())
metrics_provider = MeterProvider(resource=resource, metric_readers=[console_metric_reader])
metrics.set_meter_provider(metrics_provider)
agent = Agent(tools=[calculator])
result = agent("what is 16*16?")