Skip to content

chore: allow custom tracer provider to Agent #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

poshinchen
Copy link
Contributor

@poshinchen poshinchen commented Jun 11, 2025

Description

Allow custom tracer provider to the Agent so we don't overwrite the trace settings

Related Issues

https://github.com/strands-agents/private-sdk-python-staging/issues/68

Documentation PR

Will update documentation.

Type of Change

  • Other (please describe):
    Small update of the code

Testing

[How have you tested the change?]

  • hatch fmt --linter
  • hatch fmt --formatter
  • hatch test --all
  • Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

Checklist

  • I have read the CONTRIBUTING document
  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@poshinchen poshinchen self-assigned this Jun 11, 2025
@poshinchen poshinchen force-pushed the chore/allow-customize-tracer-provider branch 2 times, most recently from 8a727a9 to a69e342 Compare June 11, 2025 22:07
@poshinchen poshinchen added the approved-for-integ-test Indicator that a pull request has been approved to run integration tests label Jun 12, 2025
@poshinchen poshinchen marked this pull request as ready for review June 12, 2025 01:54
zastrowm
zastrowm previously approved these changes Jun 12, 2025
@poshinchen poshinchen force-pushed the chore/allow-customize-tracer-provider branch from a69e342 to 6076a17 Compare June 12, 2025 17:35
@poshinchen poshinchen force-pushed the chore/allow-customize-tracer-provider branch 2 times, most recently from dce568a to 0a8264f Compare June 12, 2025 23:11
@poshinchen poshinchen force-pushed the chore/allow-customize-tracer-provider branch from 0a8264f to 66b1f22 Compare June 12, 2025 23:26
@poshinchen poshinchen requested a review from zastrowm June 13, 2025 13:15
@poshinchen poshinchen merged commit 68740c5 into strands-agents:main Jun 13, 2025
20 of 21 checks passed
pgrayy pushed a commit to pgrayy/sdk-python that referenced this pull request Jun 18, 2025
pgrayy pushed a commit to pgrayy/sdk-python that referenced this pull request Jun 18, 2025
pgrayy pushed a commit to pgrayy/sdk-python that referenced this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-integ-test Indicator that a pull request has been approved to run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants