Skip to content

feat: Add reasoning content for openai model provider #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/strands/models/openai.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,13 @@ def stream(self, request: dict[str, Any]) -> Iterable[dict[str, Any]]:
if choice.delta.content:
yield {"chunk_type": "content_delta", "data_type": "text", "data": choice.delta.content}

if hasattr(choice.delta, "reasoning_content") and choice.delta.reasoning_content:
yield {
"chunk_type": "content_delta",
"data_type": "reasoning_content",
"data": choice.delta.reasoning_content,
}

for tool_call in choice.delta.tool_calls or []:
tool_calls.setdefault(tool_call.index, []).append(tool_call)

Expand Down
3 changes: 3 additions & 0 deletions src/strands/types/models/openai.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,9 @@ def format_chunk(self, event: dict[str, Any]) -> StreamEvent:
"contentBlockDelta": {"delta": {"toolUse": {"input": event["data"].function.arguments or ""}}}
}

if event["data_type"] == "reasoning_content":
return {"contentBlockDelta": {"delta": {"reasoningContent": {"text": event["data"]}}}}

return {"contentBlockDelta": {"delta": {"text": event["data"]}}}

case "content_stop":
Expand Down
35 changes: 25 additions & 10 deletions tests/strands/models/test_openai.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,31 +63,46 @@ def test_stream(openai_client, model):
mock_tool_call_1_part_1 = unittest.mock.Mock(index=0)
mock_tool_call_2_part_1 = unittest.mock.Mock(index=1)
mock_delta_1 = unittest.mock.Mock(
content="I'll calculate", tool_calls=[mock_tool_call_1_part_1, mock_tool_call_2_part_1]
reasoning_content="<think>",
content=None,
tool_calls=None,
)
mock_delta_2 = unittest.mock.Mock(
reasoning_content="\nOkey, the user just</think>",
content=None,
tool_calls=None,
)
mock_delta_3 = unittest.mock.Mock(
content="I'll calculate", tool_calls=[mock_tool_call_1_part_1, mock_tool_call_2_part_1], reasoning_content=None
)

mock_tool_call_1_part_2 = unittest.mock.Mock(index=0)
mock_tool_call_2_part_2 = unittest.mock.Mock(index=1)
mock_delta_2 = unittest.mock.Mock(
content="that for you", tool_calls=[mock_tool_call_1_part_2, mock_tool_call_2_part_2]
mock_delta_4 = unittest.mock.Mock(
content="that for you", tool_calls=[mock_tool_call_1_part_2, mock_tool_call_2_part_2], reasoning_content=None
)

mock_delta_3 = unittest.mock.Mock(content="", tool_calls=None)
mock_delta_5 = unittest.mock.Mock(content="", tool_calls=None, reasoning_content=None)

mock_event_1 = unittest.mock.Mock(choices=[unittest.mock.Mock(finish_reason=None, delta=mock_delta_1)])
mock_event_2 = unittest.mock.Mock(choices=[unittest.mock.Mock(finish_reason=None, delta=mock_delta_2)])
mock_event_3 = unittest.mock.Mock(choices=[unittest.mock.Mock(finish_reason="tool_calls", delta=mock_delta_3)])
mock_event_4 = unittest.mock.Mock()
mock_event_3 = unittest.mock.Mock(choices=[unittest.mock.Mock(finish_reason=None, delta=mock_delta_3)])
mock_event_4 = unittest.mock.Mock(choices=[unittest.mock.Mock(finish_reason=None, delta=mock_delta_4)])
mock_event_5 = unittest.mock.Mock(choices=[unittest.mock.Mock(finish_reason="tool_calls", delta=mock_delta_5)])
mock_event_6 = unittest.mock.Mock()

openai_client.chat.completions.create.return_value = iter([mock_event_1, mock_event_2, mock_event_3, mock_event_4])
openai_client.chat.completions.create.return_value = iter(
[mock_event_1, mock_event_2, mock_event_3, mock_event_4, mock_event_5, mock_event_6]
)

request = {"model": "m1", "messages": [{"role": "user", "content": [{"type": "text", "text": "calculate 2+2"}]}]}
response = model.stream(request)

tru_events = list(response)
exp_events = [
{"chunk_type": "message_start"},
{"chunk_type": "content_start", "data_type": "text"},
{"chunk_type": "content_delta", "data_type": "reasoning_content", "data": "<think>"},
{"chunk_type": "content_delta", "data_type": "reasoning_content", "data": "\nOkey, the user just</think>"},
{"chunk_type": "content_delta", "data_type": "text", "data": "I'll calculate"},
{"chunk_type": "content_delta", "data_type": "text", "data": "that for you"},
{"chunk_type": "content_stop", "data_type": "text"},
Expand All @@ -100,15 +115,15 @@ def test_stream(openai_client, model):
{"chunk_type": "content_delta", "data_type": "tool", "data": mock_tool_call_2_part_2},
{"chunk_type": "content_stop", "data_type": "tool"},
{"chunk_type": "message_stop", "data": "tool_calls"},
{"chunk_type": "metadata", "data": mock_event_4.usage},
{"chunk_type": "metadata", "data": mock_event_6.usage},
]

assert tru_events == exp_events
openai_client.chat.completions.create.assert_called_once_with(**request)


def test_stream_empty(openai_client, model):
mock_delta = unittest.mock.Mock(content=None, tool_calls=None)
mock_delta = unittest.mock.Mock(content=None, tool_calls=None, reasoning_content=None)
mock_usage = unittest.mock.Mock(prompt_tokens=0, completion_tokens=0, total_tokens=0)

mock_event_1 = unittest.mock.Mock(choices=[unittest.mock.Mock(finish_reason=None, delta=mock_delta)])
Expand Down