Skip to content

fix: Handle empty choices in OpenAI model provider #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mrityunjayshukla
Copy link
Contributor

Description

Fixes bug 136 IndexError: list index out of range in src/strands/models/openai.py during streaming, we should guard against empty choices lists in the OpenAI response. This pattern is seen in other repos and is a common defensive fix for OpenAI's streaming API, which may emit events without any choices.

Related Issues

136

Documentation PR

N/A

Type of Change

  • Bug fix

Testing

[How have you tested the change?]

  • hatch fmt --linter
  • hatch fmt --formatter
  • hatch test --all
  • Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

Checklist

  • I have read the CONTRIBUTING document
  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mrityunjayshukla mrityunjayshukla requested a review from a team as a code owner June 6, 2025 08:19
pgrayy
pgrayy previously approved these changes Jun 6, 2025
@pgrayy pgrayy enabled auto-merge (squash) June 6, 2025 17:39
auto-merge was automatically disabled June 6, 2025 18:02

Head branch was pushed to by a user without write access

@pgrayy pgrayy merged commit a64e80d into strands-agents:main Jun 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants