generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 499
fix: Fix broken converstaion with orphaned toolUse #1123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Unshure
merged 2 commits into
strands-agents:main
from
Unshure:conversation_manager_hook
Nov 3, 2025
Merged
fix: Fix broken converstaion with orphaned toolUse #1123
Unshure
merged 2 commits into
strands-agents:main
from
Unshure:conversation_manager_hook
Nov 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b1409c to
d72c1fc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
d72c1fc to
c9190d4
Compare
c9190d4 to
abcf2ed
Compare
abcf2ed to
a778116
Compare
zastrowm
previously approved these changes
Nov 3, 2025
afarntrog
previously approved these changes
Nov 3, 2025
afarntrog
reviewed
Nov 3, 2025
a778116 to
4a7a9de
Compare
afarntrog
approved these changes
Nov 3, 2025
zastrowm
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes previously broken sessions with orphaned toolUses, and applies a fix for this issue going forward.
The issue was that when a session is stopped with
ToolUseas the latest message (i.e. a tools execution is stopped), the session is persisted in a state where the conversation is no longer valid.In this case, when customers restore an agent from session, they try to invoke it again, leading to a conversation that looks like this:
This results in a validation exception where there is an orphaned tool use persisted in session history.
This PR fixes this by:
One thing to note is that for existing broken sessions, we are not fixing the session in the persisted storage, just adding a temporary "toolResult" to the agent messages to fix it. This is because we would need to perform a backfill on messages in session to fix this issue in persistence. Instead, this stops the issue from continuing.
Related Issues
#1111
#859
Documentation PR
TODO
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.