Fix thrust namespace for CUDA 12.6 #428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affecting compilation issue mentioned here: #417 (comment). The other device-code compilation errors with CUDA 12.5 mentioned in the issue are not adressed with this PR.
Thrust changed the namespace for its implementations from
thrust::
tothrust::<<ABI_IDENTIFIER>>::
since thrust 2.3.0.For the few template specializations in iterator_impl, its necessary to to use the correct namespaces. Using the
THRUST_NAMESPACE_BEGIN/END
marcos should make sure that we always use the correct namespace, even with older CUDA Toolkit versions, but I did not exhaustively test that.