Merge pull request #108 from storybookjs/storyname-test

yannbf · web-flow · commit 90df26e8f682 · 2022-07-15T13:54:47.000+02:00
Add test for handling csf3 `name` -&gt; `storyName`
diff --git a/example/src/__snapshots__/internals.test.tsx.snap b/example/src/__snapshots__/internals.test.tsx.snap
@@ -143,3 +143,18 @@ exports[`Renders WithLocale story 1`] = `
   </div>
 </body>
 `;
+
+exports[`Renders custom name story 1`] = `
+<body>
+  <div>
+    <div>
+      Locale: 
+      en
+    </div>
+    <button
+      class="storybook-button storybook-button--medium storybook-button--secondary"
+      type="button"
+    />
+  </div>
+</body>
+`;
diff --git a/example/src/components/Button.stories.tsx b/example/src/components/Button.stories.tsx
@@ -99,3 +99,8 @@ export const StoryWithDecoratorUseHook: CSF3Story<ButtonProps> = {
     }
   ]
 };
+
+export const StoryWithName: CSF3Story<ButtonProps> = {
+  name: "custom name",
+  args: {}
+}
diff --git a/example/src/internals.test.tsx b/example/src/internals.test.tsx
@@ -37,6 +37,11 @@ test('should pass with decorators that need addons channel', () => {
   expect(buttonElement).not.toBeNull();
 });
 
+test('should convert a csf3 name to storyName', () => {
+  const ComposedStoryWithName = composeStory(stories.StoryWithName, stories.default);
+  expect(ComposedStoryWithName.storyName).toBe('custom name');
+});
+
 describe('Unsupported formats', () => {
   test('should throw error StoryFn.story notation', () => {
     const UnsupportedStory = () => <div>hello world</div>;

Original file line number	Diff line number	Diff line change
`@@ -99,3 +99,8 @@ export const StoryWithDecoratorUseHook: CSF3Story<ButtonProps> = {`
`99`	`99`	`}`
`100`	`100`	`]`
`101`	`101`	`};`
	`102`	`+`
	`103`	`+export const StoryWithName: CSF3Story<ButtonProps> = {`
	`104`	`+ name: "custom name",`
	`105`	`+ args: {}`
	`106`	`+}`